| Summary: | Button enabling problem in cookie policy selection dialog | ||
|---|---|---|---|
| Product: | [Applications] konqueror | Reporter: | Gregorio Guidi <greg_g> |
| Component: | kcookiejar | Assignee: | David Faure <faure> |
| Status: | RESOLVED FIXED | ||
| Severity: | normal | ||
| Priority: | NOR | ||
| Version: | Git | ||
| Target Milestone: | --- | ||
| Platform: | Unlisted Binaries | ||
| OS: | Linux | ||
| Latest Commit: | Version Fixed In: | 4.7.3 | |
| Sentry Crash Report: | |||
| Attachments: | Fix button enabling in cookie policy selection dialog | ||
Git commit ef882275a2dba6f9831cb0adc3e78fb359a2bc06 by Dawit Alemayehu. Committed on 18/10/2011 at 06:54. Pushed by adawit into branch 'KDE/4.7'. Enable the OK button when a new policy is selected. BUG: 284297 FIXED-IN: 4.7.3 M +7 -3 konqueror/settings/kio/policydlg.cpp http://commits.kde.org/kde-baseapps/ef882275a2dba6f9831cb0adc3e78fb359a2bc06 Git commit fc0d9e485a55fb53a4a351979d0184497dc0122b by Dawit Alemayehu. Committed on 18/10/2011 at 06:45. Pushed by adawit into branch 'master'. Enable the OK button when a new policy is selected. CCBUG: 284297 M +7 -2 konqueror/settings/kio/kcookiespolicyselectiondlg.cpp http://commits.kde.org/kde-baseapps/fc0d9e485a55fb53a4a351979d0184497dc0122b |
Created attachment 64644 [details] Fix button enabling in cookie policy selection dialog Version: Git (using Devel) OS: Linux In "Configure konqueror" -> cookies -> site policy, when clicking "Change...", the dialog to change policy shows up with the "Ok" button disabled, so just changing policy and cliking Ok is not possible. This happens because in the dialog constructor the text is set up using setText(), which does not emit textEdited and so does not trigger the enabling of the OK button. This is fixed by listening to the signal textChanged instead of textEdited: diff --git a/konqueror/settings/kio/kcookiespolicyselectiondlg.cpp b/konqueror/settings/kio/kcookiespolicyselectiondlg.cpp index 584cb1f..0a2e9bb 100644 --- a/konqueror/settings/kio/kcookiespolicyselectiondlg.cpp +++ b/konqueror/settings/kio/kcookiespolicyselectiondlg.cpp @@ -67,7 +67,7 @@ KCookiesPolicySelectionDlg::KCookiesPolicySelectionDlg (QWidget* parent, Qt::Win mUi.cbPolicy->setMinimumWidth(mUi.cbPolicy->fontMetrics().maxWidth() * 15); enableButtonOk(false); - connect(mUi.leDomain, SIGNAL(textEdited(QString)), + connect(mUi.leDomain, SIGNAL(textChanged(QString)), SLOT(slotTextChanged (QString))); mUi.leDomain->setFocus(); -- Reproducible: Always Steps to Reproduce: "Configure konqueror" -> cookies -> site policy -> "Change..." Actual Results: "Ok" button disabled Expected Results: "Ok" button enabled