Bug 284136

Summary:	After moving images the old thumbnails remain there.
Product:	[Applications] digikam	Reporter:	pochini
Component:	Thumbs-Engine	Assignee:	Digikam Developers <digikam-bugs-null>
Status:	RESOLVED FIXED
Severity:	normal	CC:	caulier.gilles, marcel.wiesweg
Priority:	NOR
Version:	2.2.0
Target Milestone:	---
Platform:	Compiled Sources
OS:	Linux
Latest Commit:		Version Fixed In:	2.5.0
Sentry Crash Report:

Description pochini 2011-10-15 22:04:13 UTC

Version:           2.2.0 (using KDE 4.6.5) 
OS:                Linux

This bug was not present in 2.1.1. When I move one image it is actually moved to the destination folder or trash, but sometimes its thumbnail also remains in the old place. Since the old thumbnail hasn't the associated image anymore it cannot be moved or deleted again. F5 does not help. This happens more often when many images are moved at once.

Reproducible: Sometimes

Steps to Reproduce:
Select some pics and hit DEL.

Actual Results:  
Pics are moved to trash, but their thumbs stay.

Expected Results:  
The thumbs should go too.

Since the bug is not reliably reproduceable, I thought is was caused by some sort of race condition. I also guessed it had to do with the notify mechanism. Digging into the diff from 2.1.1 I noticed this change:

-----
2011-09-17  Marcel Wiesweg <marcel.wiesweg@gmx.de>
	[...]Instead of imageInfosDeleted, use an interval based notify
	method which has no overhead (imageInfosDeleted can be slow
	because the list needs to be built)
-----

So I tried to revert all the changes in:

core/libs/models/imagemodel.cpp
core/libs/models/imagemodel.h
core/libs/models/imagethumbnailmodel.cpp
core/libs/models/imagethumbnailmodel.h

and the problem doesn't show up anymore.

Comment 1 Marcel Wiesweg 2011-11-05 13:14:39 UTC

What does help: Going to another album and going back? Quitting digikam and restarting?
Does it only happen with move-to-trash or also with a normal move to another album?

Comment 2 pochini 2011-11-13 20:13:05 UTC

On Sat, 05 Nov 2011 13:14:39 +0000
Marcel Wiesweg <marcel.wiesweg@gmx.de> wrote:

> https://bugs.kde.org/show_bug.cgi?id=284136
> 
> 
> 
> 
> 
> --- Comment #1 from Marcel Wiesweg <marcel wiesweg gmx de>  2011-11-05 13:14:39 ---
> What does help: Going to another album and going back? Quitting digikam and
> restarting?
> Does it only happen with move-to-trash or also with a normal move to another
> album?

Sorry for the late answer...

No, the thumbmail is still in the db after those operations. It looks like
they are never deleted.

Comment 3 pochini 2011-12-10 17:01:49 UTC

It seems this problem in Digikan 2.4.1 does not occur anymore. I'm using this version for three days and all the images I moved to the trash or to other folders didn't leave any ghost in the source folder. Furthermore, it looks like those operations are much faster than before.