Summary: | Attendee/Invites information is not updated | ||
---|---|---|---|
Product: | [Applications] kdepim | Reporter: | Ingo Ratsdorf <ingo> |
Component: | libkdepim | Assignee: | Sergio Martins <smartins> |
Status: | RESOLVED FIXED | ||
Severity: | major | CC: | smartins |
Priority: | NOR | ||
Version: | 4.9 | ||
Target Milestone: | --- | ||
Platform: | Ubuntu | ||
OS: | Linux | ||
Latest Commit: | http://commits.kde.org/kdepim/c00a67dd162b745e3466202e716d10ce33d7581e | Version Fixed In: |
Description
Ingo Ratsdorf
2011-10-14 00:27:48 UTC
I guess my last comment highlights the fact the Korganizer or akonadi does not realise that an incidence was changed when just modifying the attendees. Is that possibly not compared against changes in the source code somewhere? Who decides when to save an incidence? Akonadi, the resource (groupdav), Korganizer? (In reply to comment #1) > I guess my last comment highlights the fact the Korganizer or akonadi does not > realise that an incidence was changed when just modifying the attendees. > Is that possibly not compared against changes in the source code somewhere? > Who decides when to save an incidence? > Akonadi, the resource (groupdav), Korganizer? Check in kdepim/incidenceeditor-ng/incidenceattendee.cpp method isDirty(), somehow it isn't detecting the change. Repo: git://anongit.kde.org/kdepim Hi.
Thanks for the pointer.
I had a look at the source and can confirm that ONLY attendees and organisers are compared, not their status.
That explains why a status is ONLY recognised as changed when you change someting else in the incidence as well.
So if someone calls you via phone (yes - that happens) and confirms his attendamce, there's no way to change his status other than deleting that person and adding it back in with the updated status...
Causing confusion at the end user since he will receive two notifications from the server: one cancelled and one confirmed.
Cheers,
Ingo
On Wed, 02 Nov 2011 04:34:37 Sergio Martins wrote:
> --- Comment #2 from Sergio Martins <iamsergio gmail com> 2011-11-02 04:34:37 ---
> (In reply to comment #1)
> > I guess my last comment highlights the fact the Korganizer or akonadi does not
> > realise that an incidence was changed when just modifying the attendees.
> > Is that possibly not compared against changes in the source code somewhere?
> > Who decides when to save an incidence?
> > Akonadi, the resource (groupdav), Korganizer?
>
> Check in kdepim/incidenceeditor-ng/incidenceattendee.cpp method isDirty(),
> somehow it isn't detecting the change.
The bug is still around in 4.8 and should be easy to be fixed. See last comment re kdepim/incidenceeditor-ng/incidenceattendee.cpp method isDirty() I had a look at the source and can confirm that ONLY attendees and organisers are compared, not their status. That explains why a status is ONLY recognised as changed when you change someting else in the incidence as well. Still around 4.8.3. Plus now I cannot add any attendees any more at all when editing an existing incidence. Only when creating a new one. So it's getting worse. Moved on to KDE 4.9 and the bug is still around. Moved to 4.9.2 and bug is still there. Come on folks! I even described the solution up there. (In reply to comment #7) > Moved to 4.9.2 and bug is still there. Come on folks! I even described the > solution up there. isDirty() looks ok, it compares the attendee, which contains the status and stuff. Working on a fix. Git commit 015cd8d1f8e862a527b732c1ef7788c14d8e988a by Sergio Martins. Committed on 16/10/2012 at 02:57. Pushed by smartins into branch 'master'. Mark the editor dirty when changing RSVP, role or status. The change() signal isn't used in IncidenceAttendee. M +5 -2 incidenceeditor-ng/attendeeline.cpp http://commits.kde.org/kdepim/015cd8d1f8e862a527b732c1ef7788c14d8e988a YAY! Great stuff. That will make Korganzier almost perfect! :-) Thanks a lot! Git commit c00a67dd162b745e3466202e716d10ce33d7581e by Sergio Martins. Committed on 16/10/2012 at 02:57. Pushed by smartins into branch 'KDE/4.9'. Mark the editor dirty when changing RSVP, role or status. The change() signal isn't used in IncidenceAttendee. (cherry picked from commit 015cd8d1f8e862a527b732c1ef7788c14d8e988a) M +5 -2 incidenceeditor-ng/attendeeline.cpp http://commits.kde.org/kdepim/c00a67dd162b745e3466202e716d10ce33d7581e |