| Summary: | Konqueror (KJS) crashes on (almost) every site | ||
|---|---|---|---|
| Product: | [Applications] konqueror | Reporter: | Vadim Zhukov <persgray> |
| Component: | kjs | Assignee: | Konqueror Developers <konq-bugs> |
| Status: | RESOLVED WORKSFORME | ||
| Severity: | crash | CC: | maksim |
| Priority: | NOR | ||
| Version First Reported In: | 4.7.1 | ||
| Target Milestone: | --- | ||
| Platform: | Compiled Sources | ||
| OS: | OpenBSD | ||
| Latest Commit: | Version Fixed In: | ||
| Sentry Crash Report: | |||
|
Description
Vadim Zhukov
2011-10-12 19:54:49 UTC
What this means is that the detection of stack base isn't working. The code in kjs/collector.cpp, currentThreadStackBase() likely needs an OpenBSD-specific implementation. (In reply to comment #1) > What this means is that the detection of stack base isn't working. The code in > kjs/collector.cpp, currentThreadStackBase() likely needs an OpenBSD-specific > implementation. Yep. There was a patch introduced by previous porter: --- /usr/ports/pobj/kdelibs-4.7.1/kdelibs-4.7.1/kjs/collector.cpp.orig Sat May 21 00:24:54 2011 +++ /usr/ports/pobj/kdelibs-4.7.1/kdelibs-4.7.1/kjs/collector.cpp Tue Oct 11 04:09:12 2011 @@ -499,6 +499,12 @@ static inline void* currentThreadStackBase() static pthread_t stackThread; pthread_t thread = pthread_self(); if (stackBase == 0 || thread != stackThread) { +#if defined(__OpenBSD__) + stack_t sinfo; + pthread_stackseg_np(thread, &sinfo); + stackBase = (char *)sinfo.ss_sp - sinfo.ss_size; + stackThread = thread; +#else pthread_attr_t sattr; #if HAVE(PTHREAD_NP_H) || defined(__NetBSD__) // e.g. on FreeBSD 5.4, neundorf@kde.org @@ -517,6 +523,7 @@ static inline void* currentThreadStackBase() stackBase = (char *)stackBase + stackSize; // a matter of interpretation, apparently... assert(stackBase); stackThread = thread; +#endif } #else #error Need a way to get the stack base on this platform I'll look into it, thanks for explanation! Could you (or anyone other) tell me, please, if KDE has/plans support for architectures where stack grows up? Or where can I find such info? Dear Bug Submitter, This bug has been stagnant for a long time. Could you help us out and re-test if the bug is valid in the latest version? I am setting the status to NEEDSINFO pending your response, please change the Status back to REPORTED when you respond. Thank you for helping us make KDE software even better for everyone! Dear Bug Submitter, This bug has been in NEEDSINFO status with no change for at least 15 days. Please provide the requested information as soon as possible and set the bug status as REPORTED. Due to regular bug tracker maintenance, if the bug is still in NEEDSINFO status with no change in 30 days the bug will be closed as RESOLVED > WORKSFORME due to lack of needed information. For more information about our bug triaging procedures please read the wiki located here: https://community.kde.org/Guidelines_and_HOWTOs/Bug_triaging If you have already provided the requested information, please mark the bug as REPORTED so that the KDE team knows that the bug is ready to be confirmed. Thank you for helping us make KDE software even better for everyone! This bug has been in NEEDSINFO status with no change for at least 30 days. The bug is now closed as RESOLVED > WORKSFORME due to lack of needed information. For more information about our bug triaging procedures please read the wiki located here: https://community.kde.org/Guidelines_and_HOWTOs/Bug_triaging Thank you for helping us make KDE software even better for everyone! |