Summary: | Can not add a new operation after modifying the values on an existing one | ||
---|---|---|---|
Product: | [Applications] skrooge | Reporter: | Adrián Chaves (Gallaecio) <adrian> |
Component: | general | Assignee: | Stephane MANKOWSKI <stephane> |
Status: | RESOLVED FIXED | ||
Severity: | normal | CC: | stephane |
Priority: | NOR | ||
Version: | unspecified | ||
Target Milestone: | --- | ||
Platform: | Chakra | ||
OS: | Linux | ||
Latest Commit: | Version Fixed In: | ||
Sentry Crash Report: | |||
Attachments: |
Screenshot of my Locale Money configuration.
Screenshot of my Number Locale section under SystemSettings. |
Description
Adrián Chaves (Gallaecio)
2011-10-10 06:00:53 UTC
(In reply to comment #0) > Version: unspecified (using Devel) > OS: Linux > > I’m using version 1.0.0 in KDE SC 4.7.2 (already tagged). > > Reproducible: Always > > Steps to Reproduce: > 1. I choose last operation. > 2. I change from Transfer to Normal in the bottom (and later I change other > values with the same result). > > Actual Results: > Add and Modify buttons are still gray. Add and Modify buttons are still gray because the amount entered is wrong (written in red). So, you have to enter a valid value. Most of the time, this error is due to bad decimal or thousand separators in "Localization" KDE settings. see: http://forum.kde.org/viewtopic.php?f=210&t=97197 Could you check your settings? > > Expected Results: > They should turn on so I can modify selected operation or add a new one. > > Also, one time I got to add an operation but I wrote 4, and it was added as -4. This is normal, when the sign is not explicitly set (example: +4 or -4), then the sign of the operation is computed with the category set. > > I did not found any information in KDe UserBase about steps needed between > versions. This all happened after I upgraded Skrooge. Reopen the incident if needed Created attachment 64473 [details]
Screenshot of my Locale Money configuration.
Sorry for the late answer. I’m using gl_ES locale, and as such I have “,” as English “.”, and no thousand separator. In the previous version of Skrooge: - Numbers without a sign prefix where interpreted as +<number>. - No matter if I was using “,” or “.”, Skrooge was able to interpret the amount and change the sign to my locale’s if needed (or was keeping it in US locales, I can’t be sure). Now, I tested: 2 → Add/Modify buttons work. +2 → They don’t work. -2 → They don’t work. Same with spaces between sign and number. 2.00 → Is converted to 200 on tab, and buttons work. 2,00 → Is converted to 200 on tab, and buttons work. Hi, In fact, the most important settings are in the tab "Numbers". So, could you attach a screenshot of this page too? Created attachment 64493 [details]
Screenshot of my Number Locale section under SystemSettings.
Sure.
Hi, I found the issue. I will deliver the correction. The workaround is the put a space " " in thousand separator for number and money. Git commit e20050768c4d1b8ab6b017cd0ac8cf3a14e09abf by Stephane Mankowski. Committed on 13/10/2011 at 23:24. Pushed by smankowski into branch 'Feature'. BUG: 283683: Can not add a new operation after modifying the values on an existing one M +1 -0 CHANGELOG M +2 -2 skgbasegui/skgcalculatoredit.cpp http://commits.kde.org/skrooge/e20050768c4d1b8ab6b017cd0ac8cf3a14e09abf Thanks, will look into patching the package in my distro. Great, the only thing not working as before is the sign stuff, but you said it is normal, so I will just use the sign every time (which makes sense). Thanks a lot! (In reply to comment #10) > Great, the only thing not working as before is the sign stuff, but you said it > is normal, so I will just use the sign every time (which makes sense). > > Thanks a lot! Hi, You don't have to enter the sign each time. If sign is not specified the sign of the category is used. You can read that: http://skrooge.org/node/135 Ok, I admit that is COOL. My “bad experience” was with the only category where I can have both income and output (personal lend of money). In the rest automatic sign should always be right. Anyway, I wish the automatic sign would be applied not when you Add or Modify, but as soon as the field loses focus, so before you add a new tem or modify one, you know that Skrooge guesses for the sign. If I write 4, I would like it to turn to either +4 or -4 as soon as I leave the field. Git commit 41709b9c05dfd524b0c580f794909c7af419bae9 by Stephane Mankowski. Committed on 17/10/2011 at 08:56. Pushed by smankowski into branch 'Feature'. BUG: 283683: Can not add a new operation after modifying the values on an existing one M +36 -1 plugins/skrooge/skrooge_operation/skgoperationpluginwidget.cpp http://commits.kde.org/skrooge/41709b9c05dfd524b0c580f794909c7af419bae9 |