Summary: | cannot enter hex letters with shift key pressed | ||
---|---|---|---|
Product: | [Applications] kcalc | Reporter: | thnielsen <thnielsen> |
Component: | general | Assignee: | Evan Teran <eteran> |
Status: | RESOLVED FIXED | ||
Severity: | normal | CC: | mail, martonmiklosqdev, opensource |
Priority: | NOR | ||
Version: | unspecified | ||
Target Milestone: | --- | ||
Platform: | openSUSE | ||
OS: | Linux | ||
Latest Commit: | https://commits.kde.org/kcalc/5763ce932d66d5101c0e5bf0b6f11279716b2710 | Version Fixed In: | 19.08.0 |
Attachments: | Proposed patch |
Description
thnielsen
2011-10-07 09:13:14 UTC
The problem is that some keys, like E and D, are already mapped. E maps to x*10^ y and D to Dat. It is possible to change them in the source if noone objects ... Any news on this one? I have checked the KCalc 15.12.3 and the issue is still present. Regarding to the mapped keys: The x*10^y function is unavailable in HEX mode, and the Dat function is only available in Statistical mode, so I do not think that it should be a big objection. Created attachment 105570 [details]
Proposed patch
Adding multiple shortcuts to the same button in the ui file (like A, Shift+A) does not works on Qt 5.8.0. So I propose to handle these events in the keyPressEvent method. Patch attached. I have not reviewed the patch, but the change seems sensible to me. Please submit your patch to Phabricator if you are still around @martonmiklos. (In reply to Julian Schraner from comment #5) > I have not reviewed the patch, but the change seems sensible to me. Please > submit your patch to Phabricator if you are still around @martonmiklos. Hi Julian, Thanks for checking it out I will submit it via phabricator. Submitted to phabricator D18967. Git commit 5763ce932d66d5101c0e5bf0b6f11279716b2710 by Christoph Feck, on behalf of Miklos Marton. Committed on 10/07/2019 at 18:58. Pushed by cfeck into branch 'master'. Accept hex letters with the Shift key pressed When kcalc is switched to hexadecimal mode, the A-F characters cannot be entered when the Shift key is pressed. This patch enables this. FIXED-IN: 19.08.0 Differential Revision: https://phabricator.kde.org/D18967 M +28 -0 kcalc.cpp https://commits.kde.org/kcalc/5763ce932d66d5101c0e5bf0b6f11279716b2710 |