Bug 283481

Summary: Highlighted window should not be scaled during moving in presentwindow
Product: [Plasma] kwin Reporter: LuRan <hephooey_dev>
Component: effects-window-managementAssignee: KWin default assignee <kwin-bugs-null>
Status: RESOLVED FIXED    
Severity: normal    
Priority: NOR    
Version: git master   
Target Milestone: ---   
Platform: Compiled Sources   
OS: Linux   
Latest Commit: Version Fixed In:
Sentry Crash Report:

Description LuRan 2011-10-06 16:35:16 UTC 
Version:           git master (using Devel) 
OS:                Linux

Presentwindow keeps scaling the highlighted window when windows are moving back to their original position. This cause some overshooting effect, and the activated window shrinks back suddenly when the animation is finished. It is more obvious for smaller windows since they are usually zoomed in more by highlighting

Reproducible: Always

Steps to Reproduce:
1. Activate presentwindow effect
2. Hover to a small window and it will scaled up by the highlighting
3. Select that window and all the windows moving back to the original position

Actual Results:  
The selected window is still scaled during the animation and suddenly shrink back in the end.

Expected Results:  
The selected window should not be scaled during the exiting animation.
Comment 1 Thomas Lübking 2011-10-06 20:48:57 UTC 
Git commit 297d3161e53a5e95104c2235320d91a594c1fab2 by Thomas Lübking.
Committed on 06/10/2011 at 22:40.
Pushed by luebking into branch 'master'.

don't scale highlighted window in present windows during de/activation

BUG: 283481
it's even worse, since it interferes with generally upscaled windows
(keeps them big, applies false transition and causes a final snapback)
and windata->highlight doesn't end at zero, so the entire screen is
still a little scaled when the effect ends (and snaps down afterwards)

now it snaps down when starting the leave what is better in general
and the only usable solution for upscaled windows.
some day presentwindows might be derived from the yet-to-add
animationeffect class ;-)

M  +1    -1    kwin/effects/presentwindows/presentwindows.cpp

http://commits.kde.org/kde-workspace/297d3161e53a5e95104c2235320d91a594c1fab2