Bug 283440

Summary: table selection tool - semi-automatic dividers - improvement (patch enclosed)
Product: [Applications] okular Reporter: sabik <jiri>
Component: generalAssignee: Okular developers <okular-devel>
Status: RESOLVED FIXED    
Severity: wishlist    
Priority: NOR    
Version: unspecified   
Target Milestone: ---   
Platform: Compiled Sources   
OS: Linux   
Latest Commit: Version Fixed In:
Attachments: implementation of the feature (depends on patch from bug #279859)
updated patch as per review

Description sabik 2011-10-06 03:33:53 UTC
Created attachment 64266 [details]
implementation of the feature (depends on patch from bug #279859)

Version:           unspecified
OS:                Linux

The table selection tool as per bug #279859 requires the user to manually indicate all the column and row dividers. However, in many situations it's trivial for the tool to detect the rows and columns automatically. It can't get it right every time, but it can get it right often and some of the remaining times it can at least get close. As long as the automatically-detected column and row dividers are easy to clear, they will save more time than they will cost.

Usage: the Table Selection Tool is used as per bug #279859. However, when the whole table is selected, automatic (dashed) row and column dividers appear. While they are dashed, they can be cleared by pressing Esc. Otherwise usage is unchanged — click near the edges of the table to add and remove row and column dividers (the dashed ones become solid at this point). The table is automatically copied to the clipboard after each change. When ready, paste into another document (spreadsheet, word processor, etc). Press Esc to clear the selection (twice if there are dashed dividers).

Implementation: dividers are placed in any place where they will not intersect any letter and the gap is not zero-width. A special case is made for selections spanning multiple pages to avoid placing dividers that cannot be seen.

Reproducible: Always


Actual Results:  
The table selection tool as per bug #279859 requires the user to manually indicate all the column and row dividers.

Expected Results:  
The table selection tool takes a good guess at the column and row dividers, allowing the user to clear them easily or adjust them when it gets them wrong.

This bug depends on bug #279859.
Comment 1 sabik 2011-10-06 03:43:15 UTC
I've also uploaded the patch to the review board, https://git.reviewboard.kde.org/r/102788/
Comment 2 sabik 2011-10-14 03:51:02 UTC
Created attachment 64500 [details]
updated patch as per review
Comment 3 Albert Astals Cid 2011-10-31 15:34:11 UTC
Git commit 412e3e739e1f94362bae15f914537401c2fd4cea by Albert Astals Cid, on behalf of Jiri Baum.
Committed on 31/10/2011 at 16:33.
Pushed by aacid into branch 'master'.

table selection tool - semi-automatic dividers

BUGS: 283440
REVIEW: 102788

M  +27   -0    core/page.cpp
M  +9    -0    core/page.h
M  +37   -0    core/textpage.cpp
M  +9    -0    core/textpage.h
M  +125  -2    ui/pageview.cpp
M  +4    -1    ui/pageview.h

http://commits.kde.org/okular/412e3e739e1f94362bae15f914537401c2fd4cea
Comment 4 sabik 2011-10-31 16:15:02 UTC
Thank you!