Bug 283398

Summary:	"Outline active window title" windeco option doesn't look good/right in KDE 4.7.1
Product:	[Plasma] Oxygen	Reporter:	Nikola Schnelle <n.schnelle>
Component:	win deco	Assignee:	Hugo Pereira Da Costa <hugo.pereira.da.costa>
Status:	RESOLVED FIXED
Severity:	normal	CC:	hugo.pereira.da.costa
Priority:	NOR
Version:	unspecified
Target Milestone:	---
Platform:	Ubuntu
OS:	Linux
Latest Commit:		Version Fixed In:
Sentry Crash Report:

Description Nikola Schnelle 2011-10-05 16:07:50 UTC

Version:           unspecified (using KDE 4.7.1) 
OS:                Linux

It is very hard to explain in words this bug, so I made snapshots. Color scheme is LightBrown Oxygen from kde-look and "Outline active window title" option is enabled.

Snapshots:

KDE 4.6.5 :
http://www.dodaj.rs/f/46/jw/3JTk4o9M/snapshot23.jpg
http://www.dodaj.rs/f/M/dv/wQKRWq1/snapshot24.jpg

KDE 4.7.1
http://www.dodaj.rs/f/34/va/1QCJO3ao/snapshot2.jpg
http://www.dodaj.rs/f/28/BB/43EQ4MsE/snapshot3.jpg



Reproducible: Always

Steps to Reproduce:
Use "Outline active window title" windeco option


Expected Results:  
"Outline active window title" windeco option to look the same as it looked in KDE 4.6.5

Comment 1 Hugo Pereira Da Costa 2011-10-05 16:39:01 UTC

I can confirm the issue.
Some color is wrong on the window border outline.
Will fix.
(damn it is hard to catch. I had to browse back and forth).

Thanks for posting.

Comment 2 Hugo Pereira Da Costa 2011-10-05 17:00:18 UTC

Git commit 7f9c672146c5ad10e3255b678494ecdb482d052a by Hugo Pereira Da Costa.
Committed on 05/10/2011 at 18:55.
Pushed by hpereiradacosta into branch 'KDE/4.7'.

Turn off antialiasing when rendering window outline borders.
CCBUG: 283398

M  +7    -0    kwin/clients/oxygen/oxygenclient.cpp

http://commits.kde.org/kde-workspace/7f9c672146c5ad10e3255b678494ecdb482d052a

Comment 3 Hugo Pereira Da Costa 2011-10-05 17:00:19 UTC

Git commit 6f6d0010998a19e8b1e01c77b42a6b3b5b181b38 by Hugo Pereira Da Costa.
Committed on 05/10/2011 at 18:55.
Pushed by hpereiradacosta into branch 'master'.

Turn off antialiasing when rendering window outline borders.
CCBUG: 283398

M  +7    -0    kwin/clients/oxygen/oxygenclient.cpp

http://commits.kde.org/kde-workspace/6f6d0010998a19e8b1e01c77b42a6b3b5b181b38

Comment 4 Hugo Pereira Da Costa 2011-10-05 17:01:30 UTC

ok. That fixes it.
Some anti-aliasing problem, which was causing the previously "sharp" lines to be blurred across 2 pixels.

Pushed both to master and KDE/4.7

Comment 5 Nikola Schnelle 2011-10-05 17:09:17 UTC

Thanks a lot!