Bug 283330

Summary: shortcut conflict - zoom to 100% vs assign flag
Product: [Applications] digikam Reporter: Anders Lund <anderslund>
Component: Usability-KeyboardAssignee: Digikam Developers <digikam-bugs-null>
Status: RESOLVED FIXED    
Severity: normal CC: caulier.gilles
Priority: NOR    
Version: 2.2.0   
Target Milestone: ---   
Platform: Unlisted Binaries   
OS: Linux   
Latest Commit: Version Fixed In: 2.4.0
Sentry Crash Report:

Description Anders Lund 2011-10-04 17:54:20 UTC
Version:           2.2.0
OS:                Linux

Today trying to view an image in 100% is impossible using the familliar shortcut (CTRL + ALT + 0), because of a conflict with some other action, I think assigning some flag/mark. This other action is not available in the shortcut configuration dialog, so the problem is about unfixable (I could not come up with a good alternative for zoom to 100%).

There is no GRAVE setting for this report, but that is what it is - GRAVE!!

Reproducible: Didn't try

Steps to Reproduce:
bko sucks

Actual Results:  
it is broken with khtml

Expected Results:  
shame on you, bko

OS: Linux (i686) release 3.0-ARCH
Compiler: gcc
Comment 1 Anders Lund 2011-10-04 18:20:27 UTC
A little more on why this is so bad: I have a small screen, and my workflow includes browsing through images using the album view, assigning characters (and in the future probably som of the new marks) to decide what to do with images. To view details and sharpness, I need to view images in 100%, and working in full screen there is no way of switching back and forth without the shortcuts.

That said, I do not understand how this could slip into the release. Maybe a test tool is needed to test for these conflicts, they are very common in KDE software unfortunately!
Comment 2 Marcel Wiesweg 2011-10-29 15:20:40 UTC
The shortcuts for Rating, Pick Label and Color Label are indeed hardcoded and do not seem to be configurable (not quite sure here).
I leave it to Gilles to comment on the rationale - I believe it's behavior analogous to some competition.
Comment 3 caulier.gilles 2011-10-29 17:10:18 UTC
yes Marcel these shortcuts are hardcoded, as pro photo softwares do currently. i checked under Apple Aperture and Adobe Lightroom.

Why to do the same in digiKam : to have the same behaviour, that all...

Gilles Caulier
Comment 4 Anders Lund 2011-10-30 01:08:12 UTC
Even if the competition do so, and you want digikam to do like the competition, why does it have to be *hardcoded*? Very few people changes shortcuts, and if they do, they are aware that it is a personal descicion, and the gui clearly shows they can be reset.

That said, the shortcuts to set those flags are special, as they come in series, and from that perspective the set shortcuts makes good sense. I have started using some of them even, appreciating not to have to use ratings for selecting images for removal.

The main problem is that the conflict is present. I now use c-s-o to change the zoom to "0riginal size" (100%), and I suggest the shortcut for that action be changed so that the conflict is not present, leaving the series as is for now, since there is not even a nice way to change them as a series.
Comment 5 caulier.gilles 2011-10-30 07:45:33 UTC
Where tags are fully customizable by user, as creation, name, it's logical to let's fully customizable tags shortcuts.

Labels and rating are different. Colors, Stars, and Picks labels are feature hard coded and always available in all digiKam installation. To be homogenous everywhere, shortcuts are also hardcoded...

Gilles Caulier
Comment 6 Anders Lund 2011-10-30 07:56:15 UTC
Then let us just get the conflict solved :)
Comment 7 caulier.gilles 2011-11-11 14:01:44 UTC
Git commit 81126eb81b4085d6b6cb3d5a2d2108cbed7a7545 by Gilles Caulier.
Committed on 11/11/2011 at 14:58.
Pushed by cgilles into branch 'master'.

replace CTRL+ALT+0 to zoom to 100% by CTRL + dot.
This will simplify zooming between CTRL + and CTRL - to zoom in/out.
This fix also conflict with action to un-assign color label.
BUGS: 283330

M  +1    -1    digikam/main/digikamapp.cpp
M  +1    -1    utilities/imageeditor/editor/editorwindow.cpp
M  +2    -2    utilities/lighttable/lighttablewindow.cpp

http://commits.kde.org/digikam/81126eb81b4085d6b6cb3d5a2d2108cbed7a7545