| Summary: | Extra border added to outer edge of scrollbars GTK apps | ||
|---|---|---|---|
| Product: | [Plasma] Oxygen | Reporter: | Jared B. <nitro> |
| Component: | gtk2-engine | Assignee: | Hugo Pereira Da Costa <hugo.pereira.da.costa> |
| Status: | CLOSED FIXED | ||
| Severity: | minor | CC: | b7.10110111, hugo.pereira.da.costa, web |
| Priority: | NOR | ||
| Version: | 4.0 | ||
| Target Milestone: | --- | ||
| Platform: | Gentoo Packages | ||
| OS: | Linux | ||
| Latest Commit: | Version Fixed In: | ||
| Sentry Crash Report: | |||
|
Description
Jared B.
2011-10-01 16:03:19 UTC
I can also reproduce this issue with real GTK apps, e.g. gnome-terminal, as well as with KDE/Qt ones, like konsole. So, this looks like a problem of the style in general. Hugo, any comments? well, the pixel is here and will stay, for design reason (and was made identical for gtk and qt style). Now, We could increase the "hit" area of the scrollbars so that it includes this pixel, and fix the reported issue without changing the actual design ... Will see what I can do. Huh, that's a neat idea. Would definitely be cool with that, too, if it's possible. Appreciate you looking into it. Git commit 22195ec424bdedfd39ab115a6c9167563d3338c3 by Hugo Pereira Da Costa. Committed on 03/10/2011 at 11:20. Pushed by hpereiradacosta into branch '1.1'. improved hit area for scrollbars. CCBUG: 283143 M +1 -1 rc/gtkrc M +1 -1 src/oxygenqtsettings.cpp M +9 -4 src/oxygenstyle.cpp http://commits.kde.org/oxygen-gtk/22195ec424bdedfd39ab115a6c9167563d3338c3 Git commit afae7a89a2e404c5d64f5dd5888e26eeeeed5f71 by Hugo Pereira Da Costa. Committed on 03/10/2011 at 11:26. Pushed by hpereiradacosta into branch 'gtk3'. improved hit area for scrollbars. CCBUG: 283143 M +1 -1 rc/gtk.css M +1 -1 src/oxygenqtsettings.cpp M +9 -4 src/oxygenstyle.cpp http://commits.kde.org/oxygen-gtk/afae7a89a2e404c5d64f5dd5888e26eeeeed5f71 Git commit a2ca550bd1a3e29acdbfc52fb13630339fa17de0 by Hugo Pereira Da Costa. Committed on 03/10/2011 at 11:20. Pushed by hpereiradacosta into branch 'master'. improved hit area for scrollbars. CCBUG: 283143 M +1 -1 rc/gtkrc M +1 -1 src/oxygenqtsettings.cpp M +9 -4 src/oxygenstyle.cpp http://commits.kde.org/oxygen-gtk/a2ca550bd1a3e29acdbfc52fb13630339fa17de0 Git commit b08811b6365e58cbf1f68a496a9ab9083e6bf876 by Hugo Pereira Da Costa. Committed on 03/10/2011 at 10:52. Pushed by hpereiradacosta into branch 'KDE/4.7'. improved hit area for scrollbars. CCBUG: 283143 M +37 -17 kstyles/oxygen/oxygenstyle.cpp http://commits.kde.org/kde-workspace/b08811b6365e58cbf1f68a496a9ab9083e6bf876 Git commit 9ebbe99188043c87ab007087cb5061723f31463a by Hugo Pereira Da Costa. Committed on 03/10/2011 at 10:52. Pushed by hpereiradacosta into branch 'master'. improved hit area for scrollbars. CCBUG: 283143 M +37 -17 kstyles/oxygen/oxygenstyle.cpp http://commits.kde.org/kde-workspace/9ebbe99188043c87ab007087cb5061723f31463a ok. That fixes it in gtk (all branches) and in Qt. I also backported to earlier version, considering its a bug fix. As a matter of fact this is quite an improvement, for fullscreen windows, usability wise, So ... thanks for posting. Closing. Feel free to reopen if issue still appears (should not, unless applications set extra margins). Hugo Great improvement. Thanks, Hugo. Wow, Hugo, thanks so much. This is by far the fastest I've ever had anyone even look at one of my KDE bug reports, let alone actually fix it! :-) One question: when you say backported it, are you referring to 1.1.3? If so, is there a tarball of this update available, or would I need to pull it from the repo? I checked the tarball linked from kde-look.org, but it doesn't seem to have the update, so I may have simply misunderstood what you meant. Well, nevermind. I got impatient and just pulled the git source. Works great! Thanks again. Btw, I do have one other comment/suggestion: your manual build and install directions work great, but there seems to be no way to automatically uninstall oxygen-gtk (eg., make uninstall). Am I maybe just overlooking that? If not, have you considered adding that feature to make manually testing and uninstalling easier on users? That's not related to this bug, of course, but I didn't a separate bug report was necessary for the question. If you think it's worthwhile, though, I'll be happy to create one for this. > when you say backported it, are you referring to 1.1.3? Backporting here means cherry-picking the commit from master to 1.1 branch. > there seems to be no way to automatically uninstall oxygen-gtk Well, it's as easy as this (assuming defaults): rm -r /usr/share/themes/oxygen-gtk /usr/lib/gtk-2.0/2.10.0/engines/liboxygen-gtk.so /usr/bin/oxygen-gtk-de?o @Jared http://www.cmake.org/Wiki/CMake_FAQ#Can_I_do_.22make_uninstall.22_with_CMake.3F By default, cmake does not support uninstall. Easiest way is to remove all files that are listed in the "install_manifest.txt" manifest file, generated by cmake, in your build area. There are also instruction in the link to allow CMake to do that. Should I add it? Ruslan ? What do you think ? Thanks for the tips. I think manual removal is a perfectly fine option, but I didn't see any instructions for that, either (the install_manifest.txt file is new to me). The problem was that I didn't know what had been installed, so I didn't know what to remove. A quick note in the INSTALL file or something about install_manifest.txt should be just as effective. Agreed. Will do. > There are also instruction in the link to allow CMake to do that. Should I add
> it?
> Ruslan ? What do you think ?
I'd rather just provide an 'uninstall' make target, to automate this simple task, if you don't have real reasons to not do this.
Git commit a2d10bcadefc75d3a18bb4c332d354da04f32fb1 by Hugo Pereira Da Costa. Committed on 04/10/2011 at 17:38. Pushed by hpereiradacosta into branch '1.1'. Added "uninstall" directive. CCBUG: 283143 M +12 -0 CMakeLists.txt A +22 -0 cmake_uninstall.cmake.in http://commits.kde.org/oxygen-gtk/a2d10bcadefc75d3a18bb4c332d354da04f32fb1 |