| Summary: | Reminders not showing on start if the pc was off at their start time | ||
|---|---|---|---|
| Product: | [Applications] korganizer | Reporter: | t3ddy <t3ddy1988> |
| Component: | reminder daemon (korgac) | Assignee: | kdepim bugs <kdepim-bugs> |
| Status: | RESOLVED FIXED | ||
| Severity: | normal | CC: | andreas, chris.fritz, ewilly, Frank-Roscher, frederic.coiffier, homem.gustavo, jan.riel, jcheesman, lucabs2112, mail, nospam |
| Priority: | NOR | ||
| Version: | 4.7 | ||
| Target Milestone: | --- | ||
| Platform: | Arch Linux | ||
| OS: | Linux | ||
| See Also: | https://bugs.kde.org/show_bug.cgi?id=317656 | ||
| Latest Commit: | http://commits.kde.org/kdepim/7561d38cd6d233e2b55a7f3288ac9618337f25db | Version Fixed In: | 4.10 |
| Sentry Crash Report: | |||
| Attachments: | Proposed fix using collectionTreeFetched | ||
|
Description
t3ddy
2011-09-22 07:29:13 UTC
I've also tried with an empty profile, the problem is still present. Now on KDE 4.7.2 Kubuntu 11.10 KDE 4.7.2 Same problem and sometimes fails to load Calendar file ( icalout.ics ) at reboot Still present in KDE 4.7.3 *** This bug has been confirmed by popular vote. *** Still present in KDE 4.7.4 Still present in 4.8 The same for me: Kubuntu 11.10 kernel 3.0.0-17 64-bit, Kde 4.8.1 KOrganizer 4.8 By the way, also present in ubuntu 11.10, gnome 3.2.1, korganizer 4.7.3 Still present in Kubuntu 12.04 KDE 4.8.3 I can "fix" this bug by removing line 143 in korganizer/korgac/koalarmclient.cpp of current git: checkAlarms(); Removing this just causes checkAlarms to be called at a later point instead of right at the time of initialization - so apparently this is a kind of race condition. The list of alarms gets filled too late or korgac is started too early. As I don't have any knowledge of the codebase I unfortunately won't be able to dig into this much deeper. Please, PIM devs, look into it. This bug really cripples korganizer. I missed several birthdays and other reminders until I even noticed it. This issue seems to apply to birthdays and anniversaries from the address book, too. So you better don’t rely on korganizer if you can’t remember your wife’s birthday or your wedding anniversary... ;-) Still present here on KDE 4.8.4. Still present in KDE 4.9 on Arch Linux. Created attachment 73984 [details]
Proposed fix using collectionTreeFetched
The attached patch reliably fixes the bug in my tests. It uses the new collectionTreeFetched signal in git trunk - which was introduced by David Jarvie to fix a similar problem in KAlarm.
Disclaimer: I'm still not too familiar with Akonadi, so there could very well be problems I haven't considered.
Also, while I'm writing this: Wouldn't it be worthwhile to backport David's changes to 4.9 (along with a fix for this bug)?
This should be fixed in 4.10. My commit unfortunately wasn't able to close this bug report automatically because I had different mail addresses configured for bugs and commits - so I'll just reproduce the information below: Prevent KOrganizer from ignoring reminders that trigger during downtime Wait for all collections to be populated before performing checks for reminders. Avoids the situation where KOrganizer thinks it has already checked for outstanding reminders in all collections even though it only looked at an uninitialized, empty list of collections. BUG: 282535 FIXED-IN: 4.10 REVIEW: 106824 DIGEST: Makes KOrganizer reminders work reliably again for people who do not have KDE running 24/7. This was broken since the switch to Akonadi. I have tested this with KDE 4.10 and korganizer still does not remind me of missed events. I guess, this fix did't fix it (In reply to comment #15) > I have tested this with KDE 4.10 and korganizer still does not remind me of > missed events. I guess, this fix did't fix it Doesn't it _ever_ remind you of missed events or just sometimes? "Sometimes" I wouldn't want to rule out, cause... Akonadi. But if it doesn't work at all that would point to a more specific problem on your end. As a testcase i've created an event for the next day at 7:00 with a reminder 15mins before. Next day i started korganizer at 8:00 and noreminder came up. I will create a test calendar today, and see what happens tomorrow. I'll add the following events: - whole day event with reminder - event early in the morning, that i will definitly miss ;-) I'll report tommorow and add the calendar file, if it doesn't work. Because it could alos only be related to a CalDAV resource. With a local calendar file it works as expected. With a remote calender (CalDAV) it does not work. I have created an event in the past (with Lightning) and then started korganizer. The event was there, but no reminder was shown. I reproduced this error in the past with Kontact 4.8 using a CalDAV calendar. I can confirm this happens with CalDAV. Haven't tested without CalDAV. Looks to me like a separate bug, maybe in the ETMCalendar itself. Also: As soon as I add a DAV calendar, reminders don't even work for local calendars anymore. You should open a separate bug report describing this issue. That way it should also get more attention from the people familiar with the affected code - I'm not really the best person in this regard as I neither like nor know Akonadi very well. |