| Summary: | KWin crashes when trying to maximize window | ||
|---|---|---|---|
| Product: | [Plasma] kwin | Reporter: | Wonko <wonko> |
| Component: | general | Assignee: | KWin default assignee <kwin-bugs-null> |
| Status: | RESOLVED DUPLICATE | ||
| Severity: | crash | ||
| Priority: | NOR | ||
| Version: | unspecified | ||
| Target Milestone: | --- | ||
| Platform: | Compiled Sources | ||
| OS: | Linux | ||
| Latest Commit: | Version Fixed In: | ||
| Sentry Crash Report: | |||
|
Description
Wonko
2011-09-10 14:45:58 UTC
a) is a dupe of bug #265674 b) maximizing shaded windows is indeed broken. we need to define a sane strategy and implement it c) window tabbbing is still... sigh I could so far not reproduce this here, but it very much looks like an out of bound access in clientgroup.cpp:164 - since you volunteered for recompilation ;-) try to inject a debug output and check/post the values ... if (newVisible == c) { qDebug() << visible_ << clients_.size(); newVisible = (visible_ != clients_.size() - 1) ? clients_[visible_ + 1] : clients_[visible_ - 1]; } also i wonder why maximization should disrupt konqueror & konsole - do you have a max size rule for one of them? (or is it maybe not konsole but eg. gnome-terminal?) *** This bug has been marked as a duplicate of bug 265674 *** I thought maximizing shaded (ah, that's what it's called) windows worked fine. maybe before 4.7? I'm also very happy with window tabbing, in general. This feature is just great. For example, I switched from KMail to Claws, so I grouped Claws to the Kontact window, and it fees pretty much the same. The grouped Konqueror/Konsole windows are for handling video clips and music files, and normally I only need either of them, not both at a time. So by grouping I save space. No, there are no window rules for Konqueror and Konsole. Okay, first comes the update to 4.7.1 now, which take a whileon this PC. If the problem still happens, I will try to get you the debug output. Here's some more stuff I just was writing in parallel, but now I guess most is no news to you. Anyway, some more observations: The grouped-window title bar is somewhat smaller than it was when I saved the session. Probably of the size that each of the grouped windows had. Right-clicking on the maximize button maximizes horizontally, clicking again does nothing. Happens with those windows only - I have another Konsole grouped to a single Dolphin window, this works fine. Hmm, middle-clicking on the maximize button now works as expected. Oh, and suddenly right-clicking also does, a 2nd click restores the original size. Maybe that's because I just tried with the other grouped window? Minimizing _any_ window to title bar size and then right-clicking on the maximize button makes the title bar smaller, not maximized horizontally. And the window moves to the left screen edge. More clicks do not change the size, but move the window back. Similar things happen with middle clicks. Maximizing: yes. (mostly) unmaximizing - rather not. The restorage geometry gets polluted. The problem about tabbing is not the feature but the implementation. There were tons of unguarded pointer accesses. The developer showed up a gsoc, the then semi-maintainer somehow merged it in and for the first releases it did nothing but crash all the time. I've myself fixed at least half a dozen independent invalid pointer acceses (and at some point the dozen accesses in an entire file which randomly crashed one or another) - and i don#t really don't use tabbing. Martin and other developers have probably fixed about the same amount. And evertytime we (ok: "I") think "that's been the last one" there another one to show up. I've so far refused to support tabbing in the bespin decoration for only this reason and even if i get banned for this: the tabbing code is crap. > Maybe that's because I just tried with the other grouped window? Yes. For some reason the tabbing code believes to not be able to keep the maximized clients tabbed. That's why i've asked for the rule. > Minimizing _any_ window to title bar size and then right-clicking Yes, (partial) maximizing of shaded windows is broken. On my list - but not the very top.... > I've so far refused to support tabbing in the bespin decoration for only
> this reason and even if i get banned for this: the tabbing code is crap.
I fully agree on that statement when remembering how I tried to implement it in Aurorae and how I tried (and failed) to extend it to show tooltips for inactive tabs.
The experience with tabbing is also one of the main reasons why I consider to drop the scripting code.
|