Bug 281532

Summary: pressing Tab in subject entry box inserts a tab
Product: [Applications] kmail2 Reporter: Jonathan Marten <jjm>
Component: composerAssignee: kdepim bugs <kdepim-bugs>
Status: RESOLVED FIXED    
Severity: normal CC: cyberbeat, finex, maarten, montel, pancho.s, simone
Priority: NOR    
Version: Git (master)   
Target Milestone: ---   
Platform: Compiled Sources   
OS: Linux   
Latest Commit: http://commits.kde.org/kdepim/e770265eee6b1f55c09057a3bf789d4c44ed2dbe Version Fixed In: 4.10
Sentry Crash Report:

Description Jonathan Marten 2011-09-07 10:01:20 UTC 
Version:           Git (master) (using Devel) 
OS:                Linux

If the Tab key is pressed in the composer's "Subject" entry box, a tab appears to be inserted in the text.  I'm not sure this is even allowed by RFC822 or what happens when the message is sent, but for a single line entry field such as this the expected action would be that the focus moves to the next widget.


Reproducible: Always

Steps to Reproduce:
Open a composer window, move the cursor to the "Subject" entry box, then press the Tab key.


Actual Results:  
A tab character is inserted in the text (the cursor moves right some distance).


Expected Results:  
The focus should just be moved to the next widget in sequence (the message edit area).


Pressing Enter in the "Subject" entry box does move the focus to the message edit area, as would be expected.

The "Subject" entry box popup menu has an "Allow Tabulations" option which appears to be turned on by default.  If this is turned off, Tab moves the focus as would be expected.  The sensible thing to do for this entry field would be to force the option off and remove it from the popup menu (or at least disable it).
Comment 1 Laurent Montel 2011-09-07 10:20:35 UTC 
Ok will fix it soon.
Comment 2 Laurent Montel 2011-09-07 10:37:49 UTC 
Git commit c1294a250798bb67b50a5254453e69c75256a394 by Montel Laurent.
Committed on 07/09/2011 at 12:37.
Pushed by mlaurent into branch 'master'.

Change focus with tab start to fix bug #281532

CCBUG: 281532

M  +1    -0    messagecomposer/kmsubjectlineedit.cpp

http://commits.kde.org/kdepim/c1294a250798bb67b50a5254453e69c75256a394
Comment 3 Laurent Montel 2011-09-07 10:39:31 UTC 
Git commit f96af1c4f0deead7e07eea4299918a8da9b4fc11 by Montel Laurent.
Committed on 07/09/2011 at 12:37.
Pushed by mlaurent into branch '4.7'.

Change focus with tab start to fix bug #281532

CCBUG: 281532
(cherry picked from commit c1294a250798bb67b50a5254453e69c75256a394)

M  +1    -0    messagecomposer/kmsubjectlineedit.cpp

http://commits.kde.org/kdepim/f96af1c4f0deead7e07eea4299918a8da9b4fc11
Comment 4 Laurent Montel 2011-09-07 10:40:26 UTC 
Will not easy to disable menu entry
Not sure that it's possible in kde 4.7.x
and I don't want to duplicate ktextedit...
I will look at for kde 4.8 or kde 5.0
Comment 5 FiNeX 2011-09-14 20:53:07 UTC 
@Laurent: What do you mean? The

  setTabChangesFocus( true );  

is not enough to fix the bug?

Do you really think that this bug will not be fixed in KDE 4.7.x ? :-(  :-(  :-(  :-(  :-(  :-(
Comment 6 Simone Lazzaris 2011-09-16 13:16:22 UTC 
Oh my, I hope that this is not the case. This bug is very annoying!
Comment 7 Maarten ter Huurne 2011-09-19 16:01:42 UTC 
This worked fine until I upgraded from KDE 4.7.0 to 4.7.1. So I think it is a recent regression.
Comment 8 Maarten ter Huurne 2011-09-19 16:09:10 UTC 
In the context menu there is an option "Allow Tabulations". That option is enabled by default; after disabling it, pressing tab will change focus as expected.

Unfortunately the disabling of that setting is not preserved in the next compose dialog. Actually, I think there is no point in having that setting at all, it should just be disabled all the time. I hope there is a way in Qt or KDE to configure the input field in that way.
Comment 9 Christoph Feck 2011-09-22 14:16:52 UTC 
That's exactly what the patch does. What it does not is to remove or disable the menu item, so you will still be able to set it to "Allow Tabulations".
Comment 10 Jonathan Marten 2011-09-26 19:16:46 UTC 
*** Bug 282852 has been marked as a duplicate of this bug. ***
Comment 11 Bernd Oliver Sünderhauf 2012-05-31 00:15:20 UTC 
Now that we are in 4.8 - is it possible to hide the "Allow Tabulations" context menu item?
Comment 12 Laurent Montel 2012-08-24 10:53:22 UTC 
Git commit bcea3c0c0b281dda74c1f1afe0a2b6d39c0d0a29 by Montel Laurent.
Committed on 24/08/2012 at 12:52.
Pushed by mlaurent into branch 'KDE/4.10'.

Allow to hide tab action (need by kmail subject line)

Fix Bug 281532 - pressing Tab in subject entry box inserts a tab

FIXED-IN: 4.10

M  +12   -3    kdeui/widgets/ktextedit.cpp
M  +7    -0    kdeui/widgets/ktextedit.h

http://commits.kde.org/kdelibs/bcea3c0c0b281dda74c1f1afe0a2b6d39c0d0a29
Comment 13 Laurent Montel 2012-08-24 10:54:23 UTC 
Git commit e770265eee6b1f55c09057a3bf789d4c44ed2dbe by Montel Laurent.
Committed on 24/08/2012 at 12:53.
Pushed by mlaurent into branch 'master'.

Fix Bug 281532 - pressing Tab in subject entry box inserts a tab

need kdelibs 4.10

FIXED-IN: 4.10

M  +3    -0    messagecomposer/kmsubjectlineedit.cpp

http://commits.kde.org/kdepim/e770265eee6b1f55c09057a3bf789d4c44ed2dbe