Summary: | Information Panel should 'refresh' preview when re-shown after being hidden | ||
---|---|---|---|
Product: | [Applications] dolphin | Reporter: | Kevin Brubeck Unhammer <unhammer+dill> |
Component: | panels: information | Assignee: | Peter Penz <peter.penz19> |
Status: | RESOLVED FIXED | ||
Severity: | normal | CC: | annapareddyjanardhanreddy, frank78ac |
Priority: | NOR | Keywords: | reproducible |
Version: | 16.12.2 | ||
Target Milestone: | --- | ||
Platform: | Arch Linux | ||
OS: | Linux | ||
Latest Commit: | Version Fixed In: | 4.8.0 | |
Attachments: | patch to show current preview |
Description
Kevin Brubeck Unhammer
2011-09-06 07:38:15 UTC
Thanks for the bug report! I can confirm the issue in master. Created attachment 66392 [details]
patch to show current preview
selection is passed to the seturl function, but while the panel is invisible , this selection value is ignored and nothing is done, this patch makes dolphin just to remember the current selection and return immediately if info panel is invisible
Thanks a lot for the patch! Looks good - please let me do some tests (I should have some time tomorrow) and I'll push it then :-) Git commit 90fb314fc4efbd583928f891a6efbc88ca6fa075 by Peter Penz. Committed on 06/12/2011 at 18:49. Pushed by ppenz into branch 'master'. Fix selection issue for Information Panel When the selection changes during the Information Panel is invisible, it still should get applied so that when making the Information Panel visible again a valid selection is shown. Thanks to A. Janardhan Reddy for the patch! (Additionally the obsolete check for an empty selection has been removed, as this cannot happen anymore with the new view engine) BUG: 281452 FIXED-IN: 4.8.0 M +3 -11 dolphin/src/panels/information/informationpanel.cpp http://commits.kde.org/kde-baseapps/90fb314fc4efbd583928f891a6efbc88ca6fa075 |