Summary: | libkvkontakte addition break parallel builds | ||
---|---|---|---|
Product: | [Applications] digikam | Reporter: | Francesco Riosa <vivo75+kde> |
Component: | Plugin-WebService-Vkontakte | Assignee: | Digikam Developers <digikam-bugs-null> |
Status: | RESOLVED FIXED | ||
Severity: | normal | CC: | aspotashev, caulier.gilles |
Priority: | NOR | ||
Version: | 1.0.0 | ||
Target Milestone: | --- | ||
Platform: | Gentoo Packages | ||
OS: | Linux | ||
Latest Commit: | Version Fixed In: | 2.2.0 | |
Sentry Crash Report: | |||
Attachments: | make log |
forgive me it break also at -j1 but much later Linking CXX shared module ../../../lib/kipiplugin_gpssync.so [ 46%] Built target kipiplugin_gpssync [ 46%] Built target kvkontakte_automoc [ 46%] Building CXX object extra/libkvkontakte/libkvkontakte/CMakeFiles/kvkontakte.dir/kvkontakte_automoc.cpp.o In file included from /srv/git/digikam-sc/build/extra/libkvkontakte/libkvkontakte/moc_messageinfo.cpp:10:0, from /srv/git/digikam-sc/build/extra/libkvkontakte/libkvkontakte/kvkontakte_automoc.cpp:4: /srv/git/digikam-sc/build/extra/libkvkontakte/libkvkontakte/../../../../extra/libkvkontakte/libkvkontakte/messageinfo.h:24:48: fatal error: libkvkontakte/libkvkontakte_export.h: File o directory non esistente compilation terminated. make[2]: *** [extra/libkvkontakte/libkvkontakte/CMakeFiles/kvkontakte.dir/kvkontakte_automoc.cpp.o] Errore 1 make[1]: *** [extra/libkvkontakte/libkvkontakte/CMakeFiles/kvkontakte.dir/all] Errore 2 make: *** [all] Errore 2 Alexander, Do you have a component dedicated to your library into KDE bugzilla ? Gilles Caulier seem fixed in trunk no it's not, not completely: I'm on a 64 bit system, quite everything from digikam install in /home/vivo/usr/lib64/, libkvkontakte.so instead install in /home/vivo/usr/lib kipiplugin_vkontakte.so is installed in lib64 too and cannot find the library: digikam(10698)/KIPI (loading) KIPI::PluginLoader::Info::plugin: KIPI::PluginLoader:: createInstance returned 0 for "VKontakte.ru Exporter" ( "kipiplugin_vkontakte" ) with error: "Cannot load library /home/vivo/usr/lib64/kde4/kipiplugin_vkontakte.so: (libkvkontakte.so.1: cannot open shared object file: No such file or directory)" I'm using -DDIGIKAMSC_USE_PRIVATE_KDEGRAPHICS=1 cmake option (In reply to comment #2) > Do you have a component dedicated to your library into KDE bugzilla ? No. Alexander, Component created : https://bugs.kde.org/editproducts.cgi?action=edit&product=libkvkontakte Gilles Caulier CMakeLists.txt contain the following: # set up install directories. INCLUDE_INSTALL_DIR and LIB_INSTALL_DIR must not be absolute paths set(LIB_INSTALL_DIR_SUFFIX "" CACHE STRING "The directories where to install libraries to") set(LIB_INSTALL_DIR lib${LIB_INSTALL_DIR_SUFFIX} ) set(CMAKECONFIG_INSTALL_DIR ${LIB_INSTALL_DIR}/cmake/LibKVkontakte ) which other plugins don't do, they simply use LIB_INSTALL_DIR, don't set it. Git commit bf9ffc8d808676f0ed371fbe190e10e2f85888e0 by Alexander Potashev. Committed on 09/09/2011 at 20:48. Pushed by aspotashev into branch 'master'. Do not explicitly set LIB_INSTALL_DIR BUG:281439 M +0 -3 CMakeLists.txt http://commits.kde.org/libkvkontakte/bf9ffc8d808676f0ed371fbe190e10e2f85888e0 (In reply to comment #7) > which other plugins don't do, they simply use LIB_INSTALL_DIR, don't set it. Are you happy now? (In reply to comment #9) > (In reply to comment #7) > > which other plugins don't do, they simply use LIB_INSTALL_DIR, don't set it. > > Are you happy now? yes, not tryed the component because I'm barely speaking english and russian is a no go. Your answer seem a bit disappointed, please understand that I wasn't in any way trying to be imperative and only reported the bug because seemed nobody other noticed it. Not using it, for me the fix was as simple as commenting out the CMakeFile entry. Also when reporting this I was working on a bug introduced by me which was angering other developers, a situation I really dislike, which with the limited (nigtly) time at my disposal was trying to fix ASAP. Thus the quickly written report, and my return to the problem in more than one step. easy, Francesco This bug report was about building/installing. In regard to run-time bugs, there will be enough people to test this plugin. |
Created attachment 63425 [details] make log Version: 2.2.0 (using KDE 4.7.0) OS: Linux At a first look seem to be a generated header which is included in some files, but without a lock. If no-one is already familiar with the library I can take a look at this and provide a patch (it's a good thing to learn ;) /usr/bin/time -v cmake \ -DCMAKE_INSTALL_PREFIX=${HOME}/usr \ -DSYSCONF_INSTALL_DIR=${HOME}/etc \ -DCMAKE_INSTALL_DO_STRIP=OFF \ -DCMAKE_BUILD_TYPE=Debugfull \ -DDIGIKAMSC_USE_PRIVATE_KDEGRAPHICS=1 \ .. &> log_cmake \ && tail -n22 log_cmake | egrep -e '^==' -e 'User time|System time|Percent of CPU|Elapsed' \ && /usr/bin/time -v make -j --max-load 4 &> log_make Generating backend-osm-rg.moc Scanning dependencies of target libmd5 Scanning dependencies of target kvkontakte [ 9%] [ 9%] Building CXX object extra/kipi-plugins/dngconverter/CMakeFiles/libmd5.dir/libmd5_automoc.cpp.o Building CXX object extra/kipi-plugins/dngconverter/CMakeFiles/libmd5.dir/dngwriter/extra/md5/MD5.cpp.o Generating batchdialog.moc [ 9%] [ 9%] Building CXX object extra/libkvkontakte/libkvkontakte/CMakeFiles/kvkontakte.dir/kvkontakte_automoc.cpp.o Building CXX object extra/libkvkontakte/libkvkontakte/CMakeFiles/kvkontakte.dir/authenticationdialog.cpp.o Generating gpssyncdialog.moc [ 9%] Building CXX object extra/libkvkontakte/libkvkontakte/CMakeFiles/kvkontakte.dir/userinfojob.cpp.o In file included from /srv/git/digikam-sc/build/extra/libkvkontakte/libkvkontakte/moc_messageinfo.cpp:10:0, from /srv/git/digikam-sc/build/extra/libkvkontakte/libkvkontakte/kvkontakte_automoc.cpp:4: /srv/git/digikam-sc/build/extra/libkvkontakte/libkvkontakte/../../../../extra/libkvkontakte/libkvkontakte/messageinfo.h:24:48: fatal error: libkvkontakte/libkvkontakte_export.h: File o directory non esistente compilation terminated. make[2]: *** [extra/libkvkontakte/libkvkontakte/CMakeFiles/kvkontakte.dir/kvkontakte_automoc.cpp.o] Errore 1 make[2]: *** Attesa dei processi non terminati.... In file included from /srv/git/digikam-sc/extra/libkvkontakte/libkvkontakte/userinfojob.cpp:20:0: /srv/git/digikam-sc/extra/libkvkontakte/libkvkontakte/userinfojob.h:23:41: fatal error: libkvkontakte/vkontaktejobs.h: File o directory non esistente compilation terminated. make[2]: *** [extra/libkvkontakte/libkvkontakte/CMakeFiles/kvkontakte.dir/userinfojob.cpp.o] Errore 1 Linking CXX static library ../../../lib/liblibmd5.a In file included from /srv/git/digikam-sc/extra/libkvkontakte/libkvkontakte/authenticationdialog.cpp:20:0: /srv/git/digikam-sc/extra/libkvkontakte/libkvkontakte/authenticationdialog.h:25:48: fatal error: libkvkontakte/libkvkontakte_export.h: File o directory non esistente compilation terminated. make[2]: *** [extra/libkvkontakte/libkvkontakte/CMakeFiles/kvkontakte.dir/authenticationdialog.cpp.o] Errore 1 make[1]: *** [extra/libkvkontakte/libkvkontakte/CMakeFiles/kvkontakte.dir/all] Errore 2 make[1]: *** Attesa dei processi non terminati.... Reproducible: Sometimes Steps to Reproduce: make -j --max-load 4 Expected Results: Expected Results