Summary: | System-config-printer-kde STILL doesn't request root when opened directly | ||
---|---|---|---|
Product: | [Plasma] system-config-printer-kde | Reporter: | Eric Griffith <EGriffith92> |
Component: | general | Assignee: | Jonathan Riddell <jr> |
Status: | RESOLVED FIXED | ||
Severity: | normal | CC: | chgonzalezg, EGriffith92, kevin.kofler, rdieter |
Priority: | NOR | ||
Version: | unspecified | ||
Target Milestone: | --- | ||
Platform: | Fedora RPMs | ||
OS: | Linux | ||
Latest Commit: | Version Fixed In: |
Description
Eric Griffith
2011-08-22 19:50:12 UTC
This is probably distro specific, root access is generally not needed in ubuntu to change cups settings through the cups interface used by s-c-p-k. What distro do you use? The fact that root access is needed in the first place is indeed a bug. The problem is that the system-config-printer-kde code doesn't properly implement the authentication classes, the implementation is still stubbed out. So it can't set anything as non-root. It needs to call the cups-pk-helper like the GTK+ system-config-printer does, then we can do away with running the stuff as root. I see commented out authentication code in at least these 2 places: https://projects.kde.org/projects/kde/kdeutils/printer-applet/repository/revisions/master/entry/authconn.py#L25 https://projects.kde.org/projects/kde/kdeutils/printer-applet/repository/revisions/master/entry/printer-applet.py#L486 (On Fedora, you need to authenticate to PolicyKit with the root password to be able to change printer settings from a s-c-p-kde as non-root.) fwiw, marking confirmed The new printer module that got added in either 4.9 or 4.10 fixes this issue, apparently the code was refactored enough to properly request root when needed-- even when called from the menu directly instead of through System Settings. Marking as fixed. The new code is completely different, it got rewritten from scratch in C++ rather than Python. |