| Summary: | KDevelop-4.2.3 crashes on startup. | ||
|---|---|---|---|
| Product: | [Applications] kdevelop | Reporter: | Nils Larsson <ni1s> |
| Component: | Build tools: CMake | Assignee: | kdevelop-bugs-null |
| Status: | RESOLVED FIXED | ||
| Severity: | crash | CC: | aleixpol |
| Priority: | HI | ||
| Version First Reported In: | 4.2.3 | ||
| Target Milestone: | 4.2.3 | ||
| Platform: | Gentoo Packages | ||
| OS: | Linux | ||
| Latest Commit: | Version Fixed/Implemented In: | ||
| Sentry Crash Report: | |||
|
Description
Nils Larsson
2011-08-22 16:20:57 UTC
please run kdevelop through valgrind and show us the output: valgrind --track-origins=yes --num-callers=25 kdevelop Aleix, I just had a look at the sources:
bool OptionAst::parseFunctionInfo( const CMakeFunctionDesc& func )
{
if(func.name.toLower()!="option" || (func.arguments.count()<2 && func.arguments.count()>3))
return false;
...
the || (...) stuff is always false as func.arguments.count() cannot be <2 && >3! This is most definitely an error which could lead to crashes like the above in the following code in release-builds.
Completly forgot about this one. Sorry. Anyway, I havnt triggerd it in ages, so WORKSFORME now? not closing it until aleix commented on my "code review" - there is an error there as far as I saw the last time (see above) Git commit 1bb44fda994a15846fb3107bc3afa0fed818d00b by Aleix Pol. Committed on 13/12/2011 at 18:16. Pushed by apol into branch 'master'. Fix OptionAST precondition. BUG: 280581 M +1 -1 projectmanagers/cmake/parser/cmakeast.cpp http://commits.kde.org/kdevelop/1bb44fda994a15846fb3107bc3afa0fed818d00b |