Bug 280373

Summary:	kst crashes when i do a despike filter
Product:	[Applications] kst	Reporter:	gandilo
Component:	plugins	Assignee:	kst
Status:	RESOLVED FIXED
Severity:	normal	CC:	netterfield
Priority:	NOR
Version:	2.0.3
Target Milestone:	---
Platform:	Ubuntu
OS:	Linux
Latest Commit:		Version Fixed In:
Sentry Crash Report:

Description gandilo 2011-08-18 18:51:42 UTC

Version:           2.0.3 (using KDE 4.6.2) 
OS:                Linux

kst crashes when I do a despike filter. Other types of filters don't crash. It doesn't crash if I do another type of filter first, and then do a despike filter after that. 
Error message is:
ASSERT: "isPtrValid()" in file /build/buildd/kst2-2.0.3svn20110810/src/libkst/sharedptr.h, line 170
Aborted

Reproducible: Always

Steps to Reproduce:
right click on plot->filter->select vector->despike.
Or from the menu Create->Filter Plugin->Despike Filter.
Leave filter settings as default.

Actual Results:  
crash

Expected Results:  
display a despike filtered vector in the plot

OS: Linux

Comment 1 Nicolas Brisset 2011-08-19 14:53:37 UTC

I can confirm the bug. We have to fix it.
I don't know if it's the same, but I also have a crash on the same assert when loading one of my test files...

Comment 2 Netterfield 2011-08-22 16:47:42 UTC

SVN commit 1248918 by netterfield:

Add out of memory heuristics to change vector range dialog.
Not implemented in anything resembling an intelligent way under windows or mac.

Attempt to fix despike filter crash.
CCBUG: 280373 

should be tested still.


 M  +12 -18    libkst/datacollection.cpp  
 M  +2 -0      libkst/datacollection.h  
 M  +0 -1      libkst/scalar.cpp  
 M  +32 -0     libkstapp/changedatasampledialog.cpp  
 M  +2 -5      libkstapp/datawizard.cpp  
 M  +1 -1      libkstapp/memorywidget.cpp  
 M  +1 -0      libkstapp/plotitem.cpp  
 M  +10 -5     plugins/filters/despike/filterdespike.cpp  
 M  +6 -3      widgets/scalarselector.cpp  


WebSVN link: http://websvn.kde.org/?view=rev&revision=1248918

Comment 3 Netterfield 2011-08-23 16:23:20 UTC

Confirmed fixed in previous commit.

Comment 4 Nicolas Brisset 2011-08-23 16:35:19 UTC

Barth,

I have another crash case with a test file here, and it seems to crash in a very similar way in butterworth_lowpass.cpp at line 149 (same assert). I don't have time to investigate that further right now, but maybe there is a systematic bug in a number of plugins. 
Maybe you could do a quick cross-check that the issue you fixed in despike is not also lurking elsewhere?

Comment 5 Nicolas Brisset 2011-08-23 16:42:50 UTC

Hum, looking at the XML inside the .kst file (one I had created to test version 2.0.3rc4) I noticed that one data source was missing the fileRelative attribute. When adding it back, it now works. I don't know why this attribute was missing, but the crash in the plugin seems to have been linked with missing data.
Possibly still worth investigating, though, as plugins crashing the whole app are a real pain! I don't know if we could make it more robust, but it would certainly be nice.