Bug 279805

Summary:	Hatching brush does not work until you change some settings
Product:	[Applications] krita	Reporter:	Dmitry Kazakov <dimula73>
Component:	Brush engines	Assignee:	pentalis
Status:	RESOLVED FIXED
Severity:	normal	CC:	pentalis
Priority:	NOR
Version:	unspecified
Target Milestone:	---
Platform:	Unlisted Binaries
OS:	Linux
Latest Commit:		Version Fixed In:

Description Dmitry Kazakov 2011-08-10 11:16:39 UTC

1) Open Krita
2) Open PaintOp Settings toolbox
3) Select Hatching brush paintop. Do not change any parameters! Let the default values work
4) Try to paint -- it doesn't paint
5) Go back to the toolbox and and change any value
6) painting works

Investigation showed that KisPropertiesConfiguration inside the preset doesn't have "brush_definition" section so KisBrushBasedPaintOp isn't loaded.

Comment 1 pentalis 2011-08-10 11:18:40 UTC

I'll look into this

Comment 2 Dmitry Kazakov 2011-08-12 16:57:12 UTC

Git commit 5add74b547158476a142a7aa3199fea7ab01f80b by Dmitry Kazakov.
Committed on 10/08/2011 at 13:37.
Pushed by dkazakov into branch 'krita_strokes_framework_kazakov'.

Fixed a unittest for Hatching paintop (another preset)

There is a problem with the default preset. Bug reported.
CCBUG:279805

M  +-    --    krita/ui/tests/data/hatching_30px.kpp
A  +-    --    krita/ui/tests/data/freehand/freehand_hatching_30px.kpp_incremental_cancelled_internal.png
A  +-    --    krita/ui/tests/data/freehand/freehand_hatching_30px.kpp_incremental_finished_external.png
A  +-    --    krita/ui/tests/data/freehand/freehand_hatching_30px.kpp_indirect_cancelled_internal.png
A  +-    --    krita/ui/tests/data/freehand/freehand_hatching_30px.kpp_incremental_finished_internal.png
A  +-    --    krita/ui/tests/data/freehand/freehand_hatching_30px.kpp_incremental_cancelled_external.png
A  +-    --    krita/ui/tests/data/freehand/freehand_hatching_30px.kpp_indirect_finished_internal.png
A  +-    --    krita/ui/tests/data/freehand/freehand_hatching_30px.kpp_indirect_finished_external.png
A  +-    --    krita/ui/tests/data/freehand/freehand_hatching_30px.kpp_indirect_cancelled_external.png

http://commits.kde.org/calligra/5add74b547158476a142a7aa3199fea7ab01f80b

Comment 3 Sven Langkamp 2011-08-21 09:34:43 UTC

Git commit cdf7c768ed42c5f994488972664c7061cf4b4c32 by Sven Langkamp.
Committed on 21/08/2011 at 06:26.
Pushed by langkamp into branch 'master'.

add hatching brush default preset
BUG:279805

A  +-    --    krita/plugins/paintops/defaultpresets/hatchingbrush.kpp
M  +1    -0    krita/plugins/paintops/defaultpresets/CMakeLists.txt

http://commits.kde.org/calligra/cdf7c768ed42c5f994488972664c7061cf4b4c32