Summary: | Crash when previewing .ods document | ||
---|---|---|---|
Product: | [Applications] calligrasheets | Reporter: | Christoph Feck <cfeck> |
Component: | general | Assignee: | Calligra Sheets (KSpread) Bugs <calligra-sheets-bugs-null> |
Status: | RESOLVED FIXED | ||
Severity: | crash | CC: | sebsauer |
Priority: | NOR | ||
Version: | 2.4-snapshots | ||
Target Milestone: | --- | ||
Platform: | Compiled Sources | ||
OS: | Linux | ||
Latest Commit: | Version Fixed In: |
Description
Christoph Feck
2011-08-09 10:39:37 UTC
Calligra compiled from master yesterday. Should be fixed with aab7c1e67d68af2b8ad2382b0fb500934e4119a9. Lot of thanks for the report! Tried aab7c1e6, same crash as before. ASSERT failure in QDBusConnection::registerObject: "Invalid object path given", file /local/git/Qt/qt/src/dbus/qdbusconnection.cpp, line 731 Thank you very much for testing+reopening. Does it also still say; #11 0xb6aa9b3e in qt_message (msgType=QtFatalMsg, msg=0xb6c36438 "ASSERT failure in %s: \"%s\", file %s, line %d", ap=0xbfce6e24 "\370<\332\266\336<\332\266\260<\332\266\333\002") at /local/git/Qt/qt/src/corelib/global/qglobal.cpp:2328 in the backtrace? If yes then we still seem to miss some char*<=>QString logic. The other thing I could think (if it has a proper string now) is that we need to proper escape the strings if they contain special chars like e.g. "/" ... I am not sure what special character you mean. The filename had spaces in it, but I renamed the filename to only contain ASCII letters, but same crash. Relevant part: Thread 1 (Thread 0xb474aa50 (LWP 9534)): [KCrash Handler] #7 0xffffe424 in __kernel_vsyscall () #8 0xb51f48df in raise (sig=6) at ../nptl/sysdeps/unix/sysv/linux/raise.c:64 #9 0xb51f6220 in abort () at abort.c:92 #10 0xb63989d3 in qt_message_output (msgType=QtFatalMsg, buf=0x86f95c8 "ASSERT failure in QDBusConnection::registerObject: \"Invalid object path given\", file /local/git/Qt/qt/src/dbus/qdbusconnection.cpp, line 731") at /local/git/Qt/qt/src/corelib/global/qglobal.cpp:2282 #11 0xb6398b3e in qt_message (msgType=QtFatalMsg, msg=0xb6525438 "ASSERT failure in %s: \"%s\", file %s, line %d", ap=0xbfd15ff4 "\370\334,\266\336\334,\266\260\334,\266\333\002") at /local/git/Qt/qt/src/corelib/global/qglobal.cpp:2328 #12 0xb6398f6a in qFatal (msg=0xb6525438 "ASSERT failure in %s: \"%s\", file %s, line %d") at /local/git/Qt/qt/src/corelib/global/qglobal.cpp:2511 #13 0xb63985ba in qt_assert_x (where=0xb62cdcf8 "QDBusConnection::registerObject", what=0xb62cdcde "Invalid object path given", file=0xb62cdcb0 "/local/git/Qt/qt/src/dbus/qdbusconnection.cpp", line=731) at /local/git/Qt/qt/src/corelib/global/qglobal.cpp:2035 #14 0xb627f31a in QDBusConnection::registerObject (this=0xbfd160dc, path=..., object=0x86b6df0, options=...) at /local/git/Qt/qt/src/dbus/qdbusconnection.cpp:730 #15 0xb1a66940 in Calligra::Tables::Doc::sheetAdded (this=0x8497640, sheet=0x86b6df0) at /local/git/extragear/office/calligra/tables/part/Doc.cpp:609 #16 0xb1a66ebc in Calligra::Tables::Doc::qt_metacall (this=0x8497640, _c=QMetaObject::InvokeMetaMethod, _id=3, _a=0xbfd161e8) at /local/build/extragear/office/calligra/tables/Doc.moc:85 #17 0xb64b643a in QMetaObject::metacall (object=0x8497640, cl=QMetaObject::InvokeMetaMethod, idx=43, argv=0xbfd161e8) at /local/git/Qt/qt/src/corelib/kernel/qmetaobject.cpp:237 #18 0xb64c95bf in QMetaObject::activate (sender=0x86402f8, m=0xb1950bcc, local_signal_index=2, argv=0xbfd161e8) at /local/git/Qt/qt/src/corelib/kernel/qobject.cpp:3278 #19 0xb182591c in Calligra::Tables::Map::sheetAdded (this=0x86402f8, _t1=0x86b6df0) at /local/build/extragear/office/calligra/tables/Map.moc:127 #20 0xb1821820 in Calligra::Tables::Map::addSheet (this=0x86402f8, _sheet=0x86b6df0) at /local/git/extragear/office/calligra/tables/Map.cpp:348 #21 0xb182185f in Calligra::Tables::Map::addNewSheet (this=0x86402f8, name=...) at /local/git/extragear/office/calligra/tables/Map.cpp:354 #22 0xb1823304 in Calligra::Tables::Map::loadOdf (this=0x86402f8, body=..., odfContext=...) at /local/git/extragear/office/calligra/tables/Map.cpp:599 #23 0xb180bc5e in Calligra::Tables::DocBase::loadOdf (this=0x8497640, odfStore=...) at /local/git/extragear/office/calligra/tables/DocBase.cpp:249 I inserted a qDebug() << dbusPath; before the registerObject() call. The output is "/Map/Map/", the quotes are added by the debug call. Thanks for comment #6 which shows that somehow we end with an trailing / what explains the assert. This is fixed with commit d5270590a1350e3d1816246be3600278fb705faa now what should, theoretically, finally fix the QDBus assert. I haven't compiled yet, but since the change affects the prepended name, I doubt that it will change anything. From looking at the code, this->objectName() is empty. this->objectName() is empty? oh, oh, that's a bad sign cause it never should be... p.s. it would make it a bit easier if you can provide me a hint how to reproduce :) $> konqueror name.ods ah, makes sense. Anyways, no testing needed cause this->objectName().isEmpty()==true did guide me direct to the commit that introduced the prob :) It's fixed now with cad14fd8ef38154b4bd9f3bd28cb10f2d9b921e0. Lot of thanks for keeping on the case + testing + and all the great feedback! Git commit 8f27d49be4fd177402b339a9a9d920b25ad70102 by Srikanth Tiyyagura, on behalf of Sebastian Sauer. Committed on 11/08/2011 at 12:15. Pushed by tiyyagura into branch 'krita_resource-management-tagging-tiyyagura'. Fix Crash when previewing .ods document Be sure to proper convert from chart*/QByteArray to QString. BUG:279725 M +2 -2 tables/shape/TableTool.cpp M +1 -1 tables/shape/SheetsEditor.cpp M +1 -1 tables/shape/TableShape.cpp M +1 -1 tables/dialogs/PasteInsertDialog.cpp M +1 -1 tables/dialogs/ShowDialog.cpp M +1 -1 tables/dialogs/SortDialog.cpp M +2 -2 tables/ui/CellToolOptionWidget.cpp M +1 -1 tables/plugins/calendar/CalendarTool.cpp M +1 -1 tables/part/dialogs/SheetPropertiesDialog.cpp M +1 -1 tables/dialogs/DocumentSettingsDialog.cpp M +2 -2 tables/Sheet.cpp M +2 -2 tables/dialogs/CharacterSelectDialog.h M +1 -1 tables/dialogs/AutoFormatDialog.cpp M +1 -1 tables/dialogs/AddNamedAreaDialog.cpp M +2 -2 tables/dialogs/CharacterSelectDialog.cpp M +1 -1 tables/dialogs/GotoDialog.cpp M +1 -1 tables/part/dialogs/PreferenceDialog.cpp M +1 -1 tables/Map.cpp M +2 -2 tables/dialogs/NamedAreaDialog.cpp M +2 -2 tables/dialogs/FindDialog.h M +1 -1 tables/dialogs/GoalSeekDialog.cpp M +1 -1 tables/dialogs/DatabaseDialog.cpp M +2 -2 tables/dialogs/FindDialog.cpp http://commits.kde.org/calligra/8f27d49be4fd177402b339a9a9d920b25ad70102 Git commit 01d6f7c3cd210b3af3cab0695284d511bebdb7e2 by Srikanth Tiyyagura, on behalf of Sebastian Sauer. Committed on 12/08/2011 at 16:54. Pushed by tiyyagura into branch 'krita_resource-management-tagging-tiyyagura'. Next try to fix Crash when previewing .ods document BUG:279725 M +9 -1 tables/part/Doc.cpp http://commits.kde.org/calligra/01d6f7c3cd210b3af3cab0695284d511bebdb7e2 Git commit 845b693fde997805223fd2f6b02721e1ef6725d5 by Srikanth Tiyyagura, on behalf of Sebastian Sauer. Committed on 12/08/2011 at 17:54. Pushed by tiyyagura into branch 'krita_resource-management-tagging-tiyyagura'. and finally fix Crash when previewing .ods document regression was introduced with 8cf2d2874 BUG:279725 M +3 -12 tables/part/Doc.cpp http://commits.kde.org/calligra/845b693fde997805223fd2f6b02721e1ef6725d5 Git commit a3b86f58342c2472ff58f990c65488cd8a9eca3b by Inge Wallin, on behalf of Sebastian Sauer. Committed on 11/08/2011 at 12:15. Pushed by ingwa into branch 'nondestructive-unavail-leinir'. Fix Crash when previewing .ods document Be sure to proper convert from chart*/QByteArray to QString. BUG:279725 M +2 -2 tables/shape/TableTool.cpp M +1 -1 tables/shape/SheetsEditor.cpp M +1 -1 tables/shape/TableShape.cpp M +1 -1 tables/dialogs/PasteInsertDialog.cpp M +1 -1 tables/dialogs/ShowDialog.cpp M +1 -1 tables/dialogs/SortDialog.cpp M +2 -2 tables/ui/CellToolOptionWidget.cpp M +1 -1 tables/plugins/calendar/CalendarTool.cpp M +1 -1 tables/part/dialogs/SheetPropertiesDialog.cpp M +1 -1 tables/dialogs/DocumentSettingsDialog.cpp M +2 -2 tables/Sheet.cpp M +2 -2 tables/dialogs/CharacterSelectDialog.h M +1 -1 tables/dialogs/AutoFormatDialog.cpp M +1 -1 tables/dialogs/AddNamedAreaDialog.cpp M +2 -2 tables/dialogs/CharacterSelectDialog.cpp M +1 -1 tables/dialogs/GotoDialog.cpp M +1 -1 tables/part/dialogs/PreferenceDialog.cpp M +1 -1 tables/Map.cpp M +2 -2 tables/dialogs/NamedAreaDialog.cpp M +2 -2 tables/dialogs/FindDialog.h M +1 -1 tables/dialogs/GoalSeekDialog.cpp M +1 -1 tables/dialogs/DatabaseDialog.cpp M +2 -2 tables/dialogs/FindDialog.cpp http://commits.kde.org/calligra/a3b86f58342c2472ff58f990c65488cd8a9eca3b Git commit 455218df6d4ed1224d76118f083e66fe7f12fb28 by Inge Wallin, on behalf of Sebastian Sauer. Committed on 12/08/2011 at 16:54. Pushed by ingwa into branch 'nondestructive-unavail-leinir'. Next try to fix Crash when previewing .ods document BUG:279725 M +9 -1 tables/part/Doc.cpp http://commits.kde.org/calligra/455218df6d4ed1224d76118f083e66fe7f12fb28 |