| Summary: | Message box is shown for each single file after Reload All | ||
|---|---|---|---|
| Product: | [Applications] kate | Reporter: | Marcel Wiesweg <marcel.wiesweg> |
| Component: | general | Assignee: | KWrite Developers <kwrite-bugs-null> |
| Status: | RESOLVED FIXED | ||
| Severity: | wishlist | CC: | bluelightning, mike |
| Priority: | NOR | ||
| Version: | unspecified | ||
| Target Milestone: | --- | ||
| Platform: | openSUSE | ||
| OS: | Linux | ||
| Latest Commit: | http://commits.kde.org/kate/b9c87b449c8965ec0ea8d74d065394bc6a88146f | Version Fixed In: | 4.10.0 |
| Sentry Crash Report: | |||
|
Description
Marcel Wiesweg
2011-08-08 11:05:13 UTC
Can you please go to Settings > Configure Kate > General settings page. Is [x] Warn about files modified by foreign processes activated? If not, can you activate it and retest? Then you should get one single dialog. Please report back here as soon as possible. Thanks! Yes, when I activate it I get one single dialog at the time when the files are changed. But I may not want this dialog either. Desired behavior: When activating File -> Reload All, I have explicitly chosen to Reload, that means no dialog is necessary for files changed on disk because I already gave the answer. Of course, a dialog is needed for unsaved changes in the editor. Second problem I just discovered: When files are deleted, there is one message box per deleted file with Reload All as well, even with the above mentioned option enabled. There should be one aggregated error box just as at application startup. Please report only one issue per report. So the second problem you describe is unrelated here, please don't mix issues. Ok then, but if you are not aware that the file changed and simply invoke the action reload all, you might lose data. So I propose to let it stay this way. Christoph and other Kate developers? I see two aspects to consider: 1) If 500 files changed, you will have to answer 500 message boxes, which would need about 20 minutes. So if any dialog, it should be aggregated. This is the "BUG" part here 2) What indication is there to activate Reload All? Either, you want to throw away changes in the editor, or you want to reload files from disk. In the first case, without the slightest doubt, there must be a strong confirmation dialog. In the second case, I argue there need not be a dialog, because I just selected Reload All; but I could accept a concept where I have to confirm. But, as said in point 1, not 500 times. This is the "WISH" part which could by your decision be closed as WONTFIX. Ok, getting 500 messages boxes is certainly never what you want. Maybe we should make the dialog for all files mandatory, not an option? What do you think? Re comment #6, seems reasonable to me, FWIW. I see this a lot when switching between git branches since I tend to keep quite a lot of files open in my Kate session. I have sent a patch for this: https://git.reviewboard.kde.org/r/106383/ Git commit b9c87b449c8965ec0ea8d74d065394bc6a88146f by Dominik Haumann. Committed on 24/10/2012 at 19:03. Pushed by dhaumann into branch 'master'. fix reload all when docs are modified Thanks to Paul Eggleton for the initial patch. REVIEW: 106383 M +8 -2 kate/app/katedocmanager.cpp http://commits.kde.org/kate/b9c87b449c8965ec0ea8d74d065394bc6a88146f |