Bug 279581

Summary:	Can't compile digiKam with provided libpgf on PowerPC machine (BigEndian)
Product:	[Applications] digikam	Reporter:	Vlado Plaga <rechner>
Component:	Portability-Compilation	Assignee:	Digikam Developers <digikam-bugs-null>
Status:	RESOLVED FIXED
Severity:	normal	CC:	caulier.gilles, gnu_andrew, rschweizer
Priority:	NOR
Version:	2.0.0
Target Milestone:	---
Platform:	Compiled Sources
OS:	Linux
Latest Commit:		Version Fixed In:	2.2.0
Sentry Crash Report:
Attachments:	Fix to compile libpgf on PowerPC

Description Vlado Plaga 2011-08-07 10:41:15 UTC

Version:           2.0.0 (using KDE 4.6.2) 
OS:                Linux

The libpgf provided with digiKam does not compile on my PPC machine. I sent a message with details to libpgf-devel, but it's not available under the web interface yet. The error message was:

[...]/libpgf/Encoder.cpp: In member function ‘void CEncoder::WriteMacroBlock(CEncoder::CMacroBlock*)’:
[...]/libpgf/Encoder.cpp:313:3: error: ‘m_codeBuffer’ was not declared in this scope

I then installed libpgf-6.09.44 (even as a Debian package, using the debian directory patch from libpgf-6.11.24 and uncommenting 'dh_makeshlibs' in 'debian/rules') and digiKam compiled and runs successfully, using that version.


Reproducible: Always

Steps to Reproduce:
Try to compile digiKam 2.0.0 on a PPC system without libpgf already installed.

Actual Results:  
Compilation breaks as described.

Expected Results:  
Compilation does not break.

Comment 1 caulier.gilles 2011-08-07 11:41:45 UTC

Raphael,

This entry is for you (:-)))

Gilles Caulier

Comment 2 Andrew John Hughes 2011-08-16 01:29:31 UTC

Hitting this on Gentoo too, ppc64 box with ppc32 userland.

Comment 3 Raphael Schweizer 2011-08-16 07:20:42 UTC

This should now be fixed on SourceForge in latest revision 48 (which also includes a small speed improvement).

- Raphael

Comment 4 Vlado Plaga 2011-08-28 17:55:35 UTC

Ok, I tried revision 48 from the SVN on SourceForge and it seems to work: it compiled, and for testing purposes I also added a now image to the recompiled digiKam, for which a new thumbnail was created.

I mark this bug as fixed, but of course the new libPGF has to be included in digiKam for the problem to be gone.

Comment 5 caulier.gilles 2011-08-29 08:34:57 UTC

Raphael,

When next libpgf release is planed exactly ?

Gilles Caulier

Comment 6 Raphael Schweizer 2011-08-29 20:31:57 UTC

Gilles,

we do not release libpgf with a fixed schedule. Instead we arbitrarily push our internal repository to SourceForge once a bug is fixed or significant changes were made.

Users of libpgf are welcome to pull whenever they want to. Currently we do not expect to release a new version soon, so it might be a good moment to integrate the latest fixes into digikam (if you want to have it work out of the box on big endian systems).

- Raphael

Btw: I'm sorry that such an obvious error slipped through. We have taken measures s.t. this should not happen again.

Comment 7 caulier.gilles 2011-08-29 20:39:06 UTC

Ok, so, i will update internal libpgf with last svn trunk. 

Do you have already increased libpgf version id ?

Gilles Caulier

Comment 8 Raphael Schweizer 2011-08-29 21:25:03 UTC

Yes, version is 6.11.32, id 0x061132

Thanks, Raphael

Comment 9 John Mock 2011-09-06 15:07:49 UTC

Created attachment 63446 [details]
Fix to compile libpgf on PowerPC

Try this patch if you are building libpgf as part of the digikam build.

Comment 10 Andrew John Hughes 2011-09-07 03:02:42 UTC

Both the patch and building from SVN works for me on ppc64 with 32-bit userland.

Comment 11 caulier.gilles 2011-09-07 12:16:38 UTC

Git commit c4d8f51c0bbbb83d4f1b222e794937abc8b70cfa by Gilles Caulier.
Committed on 07/09/2011 at 14:15.
Pushed by cgilles into branch 'master'.

update internal LibPGF to svn rev. #48 (future lib version 6.11.32, not yet released)
BUG: 279581

M  +13   -13   libs/3rdparty/libpgf/BitStream.h
M  +120  -123  libs/3rdparty/libpgf/Decoder.cpp
M  +23   -10   libs/3rdparty/libpgf/Decoder.h
M  +99   -101  libs/3rdparty/libpgf/Encoder.cpp
M  +27   -15   libs/3rdparty/libpgf/Encoder.h
M  +125  -110  libs/3rdparty/libpgf/PGFimage.cpp
M  +21   -20   libs/3rdparty/libpgf/PGFimage.h
M  +52   -58   libs/3rdparty/libpgf/PGFplatform.h
M  +37   -35   libs/3rdparty/libpgf/PGFstream.cpp
M  +30   -24   libs/3rdparty/libpgf/PGFstream.h
M  +18   -19   libs/3rdparty/libpgf/PGFtypes.h
M  +14   -18   libs/3rdparty/libpgf/Subband.cpp
M  +8    -8    libs/3rdparty/libpgf/Subband.h
M  +44   -30   libs/3rdparty/libpgf/WaveletTransform.cpp
M  +15   -12   libs/3rdparty/libpgf/WaveletTransform.h

http://commits.kde.org/digikam/c4d8f51c0bbbb83d4f1b222e794937abc8b70cfa