Bug 279500

Summary: Advanced Color Selector ignores picked color when using its strip
Product: [Applications] krita Reporter: pentalis
Component: Color SelectorsAssignee: Adam C <bugs_kde_org2>
Status: RESOLVED FIXED    
Severity: normal CC: bugs_kde_org2, halla
Priority: NOR    
Version: git master (please specify the git hash!)   
Target Milestone: ---   
Platform: Compiled Sources   
OS: Linux   
Latest Commit: http://commits.kde.org/calligra/d7dc93e20f5d30d05ec4597961a986fe5660e862 Version Fixed In:
Sentry Crash Report:

Description pentalis 2011-08-06 04:35:45 UTC 
The Advanced Color Selector doesn't update its inner state after picking a color with the color picking tool.

This bug can be reproduced with any layout of the Advanced Color Selector, but for the sake of this example, we will select a specific version of it.

To avoid any confusion, deactivate the Shade Selector in the Advanced Color Selector, this bug is related to the strip/wheel always present in the Advanced Color Selector, not with any of its Shade Selectors.

To reproduce:
0.- Configure your color selector to take any of the shapes of the 4th row, consisting of a circle with colors and a strip above to adjust lightness.
1.- Make a patch of color on the canvas, for example a Red patch.
2.- Select a different color in the Advanced Color Selector, for example Blue.
3.- Paint a little with it.
4.- With the Color Picker Tool, pick a color from the patch created in step (1) (if you followed the example, pick from the Red patch).
5.- Now try to adjust the lightness of your shade of Red using the strip in the Advanced Color Selector, Whoa!, It suddenly switched to a shade of BLUE! (or to the color you selected in step (2)).
6.- Now that you know how the bug works, try reproducing it with different Advanced Color Selector layouts, different colors, try to use the color picking tool with a hotkey or directly selecting it; you will notice that the bug works in all those cases.

It took me several, several hours of disgruntled color picking to realize exactly what was wrong with the color selector, and finally I have found the bug!.

Please fix As Soon As Possible, it's a show stopper for anyone who uses the Advanced Color Selector solely (for example: me).
Comment 1 Adam C 2011-08-08 10:14:41 UTC 
i will look into it this week..
Comment 2 Halla Rempt 2011-08-08 14:34:48 UTC 
yay and hugs!
Comment 3 Halla Rempt 2012-02-29 11:04:01 UTC 
Okay, the fourth row shapes are broken: see also 294032
Comment 4 Halla Rempt 2012-02-29 12:35:41 UTC 
Git commit fb3cb1c8af8fe1f131147158e1dd011fac988a51 by Boudewijn Rempt.
Committed on 29/02/2012 at 12:06.
Pushed by rempt into branch 'master'.

Disable the broken color selectors for the 2.4 release
Related: bug 294032

REVERT after 2.4

M  +8    -8    krita/plugins/extensions/dockers/advancedcolorselector/kis_color_selector_combo_box.cpp

http://commits.kde.org/calligra/fb3cb1c8af8fe1f131147158e1dd011fac988a51
Comment 5 Sven Langkamp 2012-07-22 16:30:04 UTC 
Git commit 352db452a1fd10ec6668157f23a1f8442ae4e779 by Sven Langkamp.
Committed on 22/07/2012 at 18:28.
Pushed by langkamp into branch 'master'.

fix bug where the color selector was still showing the old color after picking and selecting again

M  +3    -0    krita/plugins/extensions/dockers/advancedcolorselector/kis_color_selector_wheel.cpp

http://commits.kde.org/calligra/352db452a1fd10ec6668157f23a1f8442ae4e779
Comment 6 T Zachmann 2012-07-25 16:38:29 UTC 
Git commit d7dc93e20f5d30d05ec4597961a986fe5660e862 by Thorsten Zachmann, on behalf of Sven Langkamp.
Committed on 22/07/2012 at 18:28.
Pushed by zachmann into branch 'calligra/2.5'.

fix bug where the color selector was still showing the old color after picking and selecting again
(cherry picked from commit 352db452a1fd10ec6668157f23a1f8442ae4e779)

M  +3    -0    krita/plugins/extensions/dockers/advancedcolorselector/kis_color_selector_wheel.cpp

http://commits.kde.org/calligra/d7dc93e20f5d30d05ec4597961a986fe5660e862