Bug 279490

Summary:	konsole should support configuring line spacing
Product:	[Applications] konsole	Reporter:	Anssi Hannula <anssi.hannula>
Component:	font	Assignee:	Konsole Developer <konsole-devel>
Status:	RESOLVED FIXED
Severity:	wishlist	CC:	adaptee, cfeck, halla, kde, scott.deagan, simonandric5
Priority:	NOR
Version:	2.7
Target Milestone:	---
Platform:	Mageia RPMs
OS:	Linux
Latest Commit:	http://commits.kde.org/konsole/57994c1d5ddd917ac037b7107253775a256eebfb	Version Fixed In:	4.10
Sentry Crash Report:

Description Anssi Hannula 2011-08-05 23:25:04 UTC

Version:           2.7 (using KDE 4.7.0) 
OS:                Linux

Konsole should support configuring the line spacing of the terminal.

My personal reason for wanting this support is due to a bug fix in Freetype 2.4.6 which has made the line spacing at least with my font (DejaVu Sans Mono, 10.7pt, 90dpi) smaller than I've come accustomed to ( comparison: http://onse.fi/files/kuvat/konsolespacing.png ).

Google search suggests this was a feature in KDE3 which was apparently not ported to KDE4.

Reproducible: Always

Steps to Reproduce:
Try to configure Konsole line spacing.

Actual Results:  
No such setting is found, line spacing remains unchanged.

Expected Results:  
Konsole line spacing setting is found and works.

Comment 1 Christoph Feck 2011-08-06 11:36:24 UTC

Well, should we add "line spacing" configuration to every application just because freetype changed their mind about what looks good? If the spacing should be configurable, it should be in fontconf or Qt, ideally per font.

Comment 2 Jekyll Wu 2011-08-18 02:05:38 UTC

*** Bug 235056 has been marked as a duplicate of this bug. ***

Comment 3 Jekyll Wu 2011-08-18 03:58:37 UTC

*** Bug 161495 has been marked as a duplicate of this bug. ***

Comment 4 Jekyll Wu 2012-05-09 18:55:00 UTC

I have a mixed feeling about this issue.

On one hand, I can still remember I was also somewhat annoyed by (now accustomed with) this linespaing issue after one freetype update.

On the other hand, I generally don't want to touch the code related with font rendering in konsole. Font rendering is one hot spot for bug reports, and I don't want to introduce another parameter to make the situation more complex before I have better understanding of the existing code. 

According to the git history, this configureable linespacing feature has a long history.  It was initially introduced by commit 58be7a62, 11 years ago. Most related code are still there, it is just the corresponding profile option is not defined and exposed.

So the compromise for now is define a profile option but do not provide UI for controlling it.

Comment 5 Halla Rempt 2012-05-09 19:11:01 UTC

Four years ago it was a hot issue for me... Right now, konsole works perfectly well again, and I had forgotten about my bug that was closed as a duplicate. I'm also not sure konsole should work around freetype and qt bugs...

Comment 6 Kurt Hindenburg 2012-07-10 14:49:26 UTC

Git commit 57994c1d5ddd917ac037b7107253775a256eebfb by Kurt Hindenburg.
Committed on 10/07/2012 at 16:41.
Pushed by hindenburg into branch 'master'.

Provide GUI to change line spacing

This provides a profile GUI to change the line spacing  (0-5).  Due to
the Qt4.8/BIDI issues, allowing the user to  change the spacing allows
the user to fix any issues w/ the font they are using.
REVIEW: 105478
FIXED-IN: 4.10

M  +10   -0    src/EditProfileDialog.cpp
M  +1    -0    src/EditProfileDialog.h
M  +37   -0    src/EditProfileDialog.ui
M  +2    -0    src/Profile.cpp
M  +9    -0    src/Profile.h
M  +0    -8    src/TerminalDisplay.h
M  +1    -0    src/ViewManager.cpp

http://commits.kde.org/konsole/57994c1d5ddd917ac037b7107253775a256eebfb

Comment 7 Scott Deagan 2017-12-18 09:37:43 UTC

I had no idea this setting was available! Thank you!!!