Summary: | amarok trusts CDDB too much, bad audio CD info => cannot play | ||
---|---|---|---|
Product: | [Applications] amarok | Reporter: | Jonathan Marten <jjm> |
Component: | Collections/CD | Assignee: | Amarok Developers <amarok-bugs-dist> |
Status: | RESOLVED WORKSFORME | ||
Severity: | normal | CC: | aumuell, cfeck, matej |
Priority: | NOR | ||
Version: | 2.7-git | ||
Target Milestone: | 2.8 | ||
Platform: | Compiled Sources | ||
OS: | Linux | ||
Latest Commit: | Version Fixed In: |
Description
Jonathan Marten
2011-08-05 21:26:11 UTC
Moving to wishlist, as this was never implemented. Git commit 67cab80dae61f0a72659558fa37e6b625aebfa3b by Matěj Laitl. Committed on 05/01/2013 at 23:27. Pushed by laitl into branch 'master'. AudioCdCollection: refactor initialization, trackForUrl() + cleanups Might also fix bug 279485, please test. BUGFIXES: * Audio CD: fix track recreation on startup. Related: bug 312685 FIXED-IN: 2.7 M +1 -0 ChangeLog M +193 -211 src/core-impl/collections/audiocd/AudioCdCollection.cpp M +4 -4 src/core-impl/collections/audiocd/AudioCdCollection.h M +2 -6 src/core-impl/collections/audiocd/AudioCdMeta.cpp M +0 -1 src/core-impl/collections/audiocd/AudioCdMeta.h M +0 -4 src/core-impl/collections/audiocd/support/AudioCdConnectionAssistant.cpp M +6 -1 src/core-impl/collections/support/MemoryCollection.h http://commits.kde.org/amarok/67cab80dae61f0a72659558fa37e6b625aebfa3b This is not a wishlist item, but a possible bug. Please test with Amarok 2.7 and report back, it may have been fixed by the above commit. Still not the correct results using amarok-2.7git (v2.5.0-1277-g0420cdf). The audio CD appears in the collection with the correct number of tracks, but with the track information from CDDB Information_2.txt, which is a different album (which just happens to have the same disc ID). This can be seen at http://www.freedb.org/freedb_discid_check.php for disc ID d411160f. Suppose that the general fix for situations such as this is to ask the user which is the appropriate result, in the case where the disc lookup returns multiple results. IIRC the KDE3 program kscd did this. Thank you for the feedback. Could you please test again? AFAIK current git contains the CD stack work of Tatjana, so this should be fixed. Closing for lack of feedback. Please feel free to reopen if you can still reproduce this with current git master. |