Bug 279272

Summary:	Amarok should respect global color palette in the bottom areas (currently blue)
Product:	[Applications] amarok	Reporter:	Bernhard Beschow <shentey>
Component:	general	Assignee:	Amarok Developers <amarok-bugs-dist>
Status:	RESOLVED FIXED
Severity:	wishlist	CC:	bart.cerneels, jmnovak, kfunk, myriam
Priority:	NOR
Version:	2.4.3
Target Milestone:	2.5
Platform:	Arch Linux
OS:	Linux
Latest Commit:		Version Fixed In:	2.5
Sentry Crash Report:

Description Bernhard Beschow 2011-08-03 10:16:44 UTC

Version:           2.4.3 (using KDE 4.7.0) 
OS:                Linux

Being blue-colored, the two bottom areas look a bit off in the standard color palette of KDE for the reasons explaned below.

Reproducible: Always

Steps to Reproduce:
Look at Amarok ;)

Actual Results:  
The blue color of the areas on the bottom competes with the highlighted and current entries in the playlist. As a result, the bottom areas attract lots of attention. Moreover, white text on the blue background is hard to read.

Moreover, as for the left blue area, it is unclear why it takes so much space w/o usually(?) containing any content. Why does it need to attract attention when it's usually empty? Is there really a need to attract so much attention even when a notification is available?

Expected Results:  
Amarok should attract attention to the currently selected/playing item. It should also respect the global color palette.

Comment 1 Myriam Schweingruber 2011-08-03 10:20:56 UTC

I use the default Oxygen and it looks correct here.

Comment 2 Bernhard Beschow 2011-08-03 11:52:57 UTC

@Myriam: does "correct" mean that the areas below are grey? (or whatever the background color of your palette is)

Comment 3 Myriam Schweingruber 2011-08-05 07:43:39 UTC

No, those are blue and should look blue :)

Comment 4 Bernhard Beschow 2011-08-05 19:25:57 UTC

Aha! Looks like we'd have to agree to disagree ;)

Comment 5 John Novak 2011-11-25 18:44:05 UTC

Could some additional information be posted here regarding this issue? I've been googling fruitlessly for a way to correct this, and this bug report is the only one that precisely matches the issue I see.

In my color scheme, that bottom toolbar renders in a particularly ugly pink color. No other KDE application that I can find uses that color, so Amarok is clearly doing something nonstandard here. I found that changing the global color 'Selection Background' (System Settings -> Application Appearance -> Colors -> Colors) affects the color of this toolbar; it renders in a lighter/brighter variant of the selection background color. Since this bottom area is not a selection, it doesn't seem correct that changing that color should affect this -- much less in a variant of the color. A toolbar seems like it would lead to a better display, but perhaps you have a different interpretation for it? (Since it's no longer called a status area, I'm guessing status bar colors don't make sense.)

Using Amarok 2.4.3 under KDE 4.7.3 (just did a system upgrade that picked up current versions, which is why I'm only now seeing the issue).

Thanks for clarifying where this color is coming from, and why!

Comment 6 Bart Cerneels 2011-11-29 07:33:36 UTC

(In reply to comment #5)
> Could some additional information be posted here regarding this issue? I've
> been googling fruitlessly for a way to correct this, and this bug report is the
> only one that precisely matches the issue I see.
> 
> In my color scheme, that bottom toolbar renders in a particularly ugly pink
> color. No other KDE application that I can find uses that color, so Amarok is
> clearly doing something nonstandard here. I found that changing the global
> color 'Selection Background' (System Settings -> Application Appearance ->
> Colors -> Colors) affects the color of this toolbar; it renders in a
> lighter/brighter variant of the selection background color. Since this bottom
> area is not a selection, it doesn't seem correct that changing that color
> should affect this -- much less in a variant of the color. A toolbar seems like
> it would lead to a better display, but perhaps you have a different
> interpretation for it? (Since it's no longer called a status area, I'm guessing
> status bar colors don't make sense.)
> 
> Using Amarok 2.4.3 under KDE 4.7.3 (just did a system upgrade that picked up
> current versions, which is why I'm only now seeing the issue).
> 
> Thanks for clarifying where this color is coming from, and why!


I've been working on this past weekend and am almost ready to commit a change to the regular color scheme using QPalette::Mid and ::Shadow. Will close this bug using the commit hook.

Comment 7 Myriam Schweingruber 2013-04-09 14:56:12 UTC

This has been implemented since Amarok 2.5