|
Description
Kamil Stepinski
2011-08-02 21:25:11 UTC
I agree with you and I think we can implement some new features like 1. Giving options to users to select from some pre-defined dimensions. 2. Users can have their own set of dimensions which they use frequently. 3. Having other units as well for resizing like cm and inches. Created attachment 118003 [details]
This patch solves the current bug as I've added a preset resolution list.
Now the user can select any one of the resolutions and resize the image.
Created attachment 118016 [details]
Changed the wrong code and added more functionality.
The user can now choose from pixel, percent, cms, and inches as image units.
Git commit 65d063b749c66fdf012581b70e4bf7fe2c7186b8 by Gilles Caulier. Committed on 13/02/2019 at 11:56. Pushed by cgilles into branch 'development/dplugins'. BQM resize tool: apply patch #118016 from Sambhav Dusad to add advanced settings. M +4 -693 NEWS M +128 -24 core/dplugins/bqm/transform/resize/resize.cpp M +3 -0 core/dplugins/bqm/transform/resize/resizeplugin.cpp C +0 -1 project/NEWS.6.0.0 [from: NEWS - 099% similarity] https://commits.kde.org/digikam/65d063b749c66fdf012581b70e4bf7fe2c7186b8 Hi Sambhav, please check the enabled state. If percent or centimeters are used, the other CheckBox must be disabled. Or use a QRadioButton group. Also, the value slider must be enabled if only percent or centimeter is checked. Maik Created attachment 118052 [details] attachment-19246-0.html Yeah, I already changed it and added radiobuttons. I was modifying the code more. So, thought of submitting the patch later Best, Sambhav Dusad On Thu 14 Feb, 2019, 01:46 Maik Qualmann, <bugzilla_noreply@kde.org> wrote: > https://bugs.kde.org/show_bug.cgi?id=279216 > > Maik Qualmann <metzpinguin@gmail.com> changed: > > What |Removed |Added > > ---------------------------------------------------------------------------- > CC| |metzpinguin@gmail.com > Version Fixed In| |6.1.0 > > --- Comment #5 from Maik Qualmann <metzpinguin@gmail.com> --- > Hi Sambhav, > > please check the enabled state. If percent or centimeters are used, the > other > CheckBox must be disabled. Or use a QRadioButton group. Also, the value > slider > must be enabled if only percent or centimeter is checked. > > Maik > > -- > You are receiving this mail because: > You are on the CC list for the bug. Created attachment 118067 [details]
Units are changed to radio buttons and Aspect Ratio Preserve checkbox added.
QGridLayout is used to style the items.
Git commit 8689c3e549e3749547cde4b65f5e2f9c011f35f8 by Gilles Caulier. Committed on 14/02/2019 at 13:39. Pushed by cgilles into branch 'development/dplugins'. apply patch #118067 M +72 -48 core/dplugins/bqm/transform/resize/resize.cpp https://commits.kde.org/digikam/8689c3e549e3749547cde4b65f5e2f9c011f35f8 Hi Sambhav, I polished the code of the resize BQM plugin a bit. I noticed that the function "Use Pixels" does not work. Please look again at the code and check all options. Maik Created attachment 118166 [details]
Preserve Aspect Ratio by width or height added.
The sliders are enabled even when Use Custom is not checked.
Sorry for the inconvenience.
Created attachment 118202 [details]
Added preset resolutions to the editor resize plugin.
Created attachment 118326 [details]
This patch adds different units like cm, inches, mm for image resizing.
It also adds preset resolution combobox to image editor resize plugin.
Created attachment 118984 [details]
This patch adds combobox for units. user can also change resolution of the image in pixel/inch
Created attachment 119102 [details]
When changing units, previous value should be kept.
But I can't access d->wInput->value() OR d->hInput->value() from slotUnitsChanged. And I can access d->resolution->value() from the same slot.
Where am I doing wrong?
Thanks
Created attachment 119127 [details]
Adds all the needed functionality in editor resize patch.
I think this patch resolves all the previous errors. Please review it.
Thanks for all the suggestions.
- When entering cm / mm / inch, it must be possible to enter decimal digits. - The range limits vary and are not set correctly when the units are changed. - When the units are changed, the result is constantly changing due to rounding errors and because no decimal digits are supported. Maik Created attachment 119317 [details]
Adds all the needed functionality in editor resize patch.
I have modified the previous patch and this should solve all the previous errors or rounding and decimal places.
Git commit fc620b3a5766ba4e5085a99da33839c82139470c by Maik Qualmann. Committed on 15/04/2019 at 17:29. Pushed by mqualmann into branch 'master'. apply patch #119317 from Sambhav Dusad to add features to the resize tool M +2 -1 NEWS M +455 -46 core/dplugins/editor/transform/resize/resizetool.cpp M +4 -0 core/dplugins/editor/transform/resize/resizetool.h https://commits.kde.org/digikam/fc620b3a5766ba4e5085a99da33839c82139470c Git commit fe9d5f511d0c4c1083c0c1e6b0c6f37f2ab91b1d by Maik Qualmann. Committed on 15/04/2019 at 17:32. Pushed by mqualmann into branch 'master'. polish und corrections on resize tool FIXED-IN: 6.2.0 M +247 -291 core/dplugins/editor/transform/resize/resizetool.cpp M +4 -3 core/dplugins/editor/transform/resize/resizetool.h https://commits.kde.org/digikam/fe9d5f511d0c4c1083c0c1e6b0c6f37f2ab91b1d |