Bug 279194

Summary:	kstars uses incorrect include file for OpenGL
Product:	[Applications] kstars	Reporter:	Marko Käning <mk-lists>
Component:	general	Assignee:	Akarsh Simha <akarsh.simha>
Status:	RESOLVED UNMAINTAINED
Severity:	normal	CC:	mutlaqja, snc
Priority:	NOR
Version First Reported In:	unspecified
Target Milestone:	---
Platform:	MacPorts
OS:	macOS
Latest Commit:		Version Fixed/Implemented In:
Sentry Crash Report:
Attachments:	Proposed patch patch to find OpenGL header files

Description Marko Käning 2011-08-02 18:02:27 UTC

Version:           unspecified (using KDE 4.7.0) 
OS:                OS X

kdeedu4 has split into several packages, one of which is kstars. kstars has an incorrect include file for OpenGL.

Reproducible: Always

Steps to Reproduce:
Build it

Actual Results:  
cd /opt/local/var/macports/build/_Users_aeetes_dports_kde_kstars/kstars/work/build/kstars && /Developer/usr/bin/llvm-g++-4.2   -DHAVE_OPENGL -pipe -O2 -arch x86_64  -fno-common -Woverloaded-virtual -fvisibility=hidden -Werror=return-type -fvisibility-inlines-hidden -O2 -DNDEBUG -DQT_NO_DEBUG -arch x86_64 -isysroot / -mmacosx-version-min=10.6 -I/opt/local/var/macports/build/_Users_aeetes_dports_kde_kstars/kstars/work/build/kstars -I/opt/local/var/macports/build/_Users_aeetes_dports_kde_kstars/kstars/work/kstars-4.7.0/kstars -I/opt/local/var/macports/build/_Users_aeetes_dports_kde_kstars/kstars/work/kstars-4.7.0 -I/opt/local/var/macports/build/_Users_aeetes_dports_kde_kstars/kstars/work/build -I/opt/local/var/macports/build/_Users_aeetes_dports_kde_kstars/kstars/work/kstars-4.7.0/kstars/tools -I/opt/local/var/macports/build/_Users_aeetes_dports_kde_kstars/kstars/work/kstars-4.7.0/kstars/skyobjects -I/opt/local/var/macports/build/_Users_aeetes_dports_kde_kstars/kstars/work/kstars-4.7.0/kstars/skycomponents -I/opt/local/include/KDE -I/opt/local/include/phonon -I/opt/local/include/QtXmlPatterns -I/opt/local/include/QtXml -I/opt/local/include/QtWebKit -I/opt/local/include/QtUiTools -I/opt/local/include/QtTest -I/opt/local/include/QtSvg -I/opt/local/include/QtSql -I/opt/local/include/QtScriptTools -I/opt/local/include/QtScript -I/opt/local/include/QtOpenGL -I/opt/local/include/QtNetwork -I/opt/local/include/QtMultimedia -I/opt/local/include/QtHelp -I/opt/local/include/QtDesigner -I/opt/local/include/QtDeclarative -I/opt/local/include/QtDBus -I/opt/local/include/Qt3Support -I/opt/local/include/QtGui -I/opt/local/include/QtCore -I/opt/local/share/qt4/mkspecs/default -I/opt/local/include/eigen2   -o CMakeFiles/kstars.dir/skyglpainter.o -c /opt/local/var/macports/build/_Users_aeetes_dports_kde_kstars/kstars/work/kstars-4.7.0/kstars/skyglpainter.cpp
/opt/local/var/macports/build/_Users_aeetes_dports_kde_kstars/kstars/work/kstars-4.7.0/kstars/skyglpainter.cpp:28:19: error: GL/gl.h: No such file or directory

Expected Results:  
a successful build

Comment 1 Marko Käning 2011-08-02 18:03:11 UTC

See http://trac.macports.org/ticket/30512 for reference.

Comment 2 Christoph Feck 2011-08-04 22:38:28 UTC

Created attachment 62556 [details]
Proposed patch

Could you check if this fixes the issue?

Comment 3 Marko Käning 2011-08-05 06:27:31 UTC

Sorry, it didn't work.

Comment 4 Jeremy Lavergne 2011-08-29 20:11:37 UTC

From the CMakeCache file:
{{{
//Path to a file.
KDE4_PLASMA_OPENGL_FOUND:FILEPATH=/opt/local/include/plasma/glapplet.h

//Include for OpenGL on OSX
OPENGL_INCLUDE_DIR:PATH=/System/Library/Frameworks/OpenGL.framework

//OpenGL lib for OSX
OPENGL_gl_LIBRARY:FILEPATH=/System/Library/Frameworks/OpenGL.framework
}}}

Inside this OpenGL.framework is:
{{{
$ ls -l /System/Library/Frameworks/OpenGL.framework/
total 48
lrwxr-xr-x  1 root  wheel   24 Dec  4  2010 CodeResources -> Versions/A/CodeResources
lrwxr-xr-x  1 root  wheel   24 Jun  3 16:34 Headers -> Versions/Current/Headers
lrwxr-xr-x  1 root  wheel   26 Dec  4  2010 Libraries -> Versions/Current/Libraries
lrwxr-xr-x  1 root  wheel   23 Dec  4  2010 OpenGL -> Versions/Current/OpenGL
lrwxr-xr-x  1 root  wheel   24 Jun  3 16:33 PlugIns -> Versions/Current/PlugIns
lrwxr-xr-x  1 root  wheel   26 Dec  4  2010 Resources -> Versions/Current/Resources
drwxr-xr-x  4 root  wheel  136 Dec  4  2010 Versions
}}}

This gives us this path to finding gl.h:
/System/Library/Frameworks/OpenGL.framework/Headers/gl.h

Comment 5 Jeremy Lavergne 2011-08-29 20:19:46 UTC

Similarly, these other variables are set in the CmakeCache:
{{{
//Path to a file.
QT_QTOPENGL_INCLUDE_DIR:PATH=/opt/local/include/QtOpenGL

//Path to a library.
QT_QTOPENGL_LIBRARY_DEBUG:FILEPATH=QT_QTOPENGL_LIBRARY_DEBUG-NOTFOUND

//Path to a library.
QT_QTOPENGL_LIBRARY_RELEASE:FILEPATH=/opt/local/lib/libQtOpenGL.dylib
}}}

Comment 6 Marko Käning 2011-10-17 16:28:25 UTC

There is a fix for MacOSX finally.

See http://trac.macports.org/changeset/85854 for reference.

I'll attach the patch herewith.

Comment 7 Marko Käning 2011-10-17 16:29:07 UTC

Created attachment 64640 [details]
patch to find OpenGL header files