Bug 279084

Summary: Incorrect code folding in simple ruby statements
Product: [Applications] kate Reporter: Miquel Sabaté <mikisabate>
Component: foldingAssignee: KWrite Developers <kwrite-bugs-null>
Status: RESOLVED FIXED    
Severity: normal CC: adrian.lungu89
Priority: NOR    
Version: unspecified   
Target Milestone: ---   
Platform: Compiled Sources   
OS: Linux   
Latest Commit: Version Fixed In:
Sentry Crash Report:
Attachments: And this image is from Kate's lastest version (git).
Old kate version.

Description Miquel Sabaté 2011-08-01 20:45:59 UTC 
Version:           unspecified (using KDE 4.7.0) 
OS:                Linux

This bug appears with the new KateCodeFolding. If you're writing some Ruby code, you'll notice incorrect code folding in cases such as if-else statements, or begin statements, etc. I cannot reproduce this bug using older versions of Kate. I'll attach two images showing the difference between older Kate versions and  one with the new Code Folding engine (git master).

Reproducible: Always

Steps to Reproduce:
Just write some ruby code.

Actual Results:  
Incorrect code folding.

Expected Results:  
A valid code folding as it was in older Kate versions.
Comment 1 Miquel Sabaté 2011-08-01 20:47:48 UTC 
Created attachment 62441 [details]
And this image is from Kate's lastest version (git).
Comment 2 Miquel Sabaté 2011-08-01 20:49:29 UTC 
Created attachment 62442 [details]
Old kate version.
Comment 3 Adrian 2011-08-02 11:32:01 UTC 
It's look like Ruby's folding it's a little different (there are keywords, not special characters (like C) or tabs (like Python). I found the issue and will I am working to find a solution now. I hope that at the end of the day this will be solved.

Adrian
Comment 4 Adrian 2011-08-02 19:07:35 UTC 
Git commit b6052e4b8e5b7910ced8c31977a30a14de861961 by Adrian Lungu.
Committed on 02/08/2011 at 21:03.
Pushed by lungu into branch 'master'.

BUG: 279084

Problem: Ruby uses keywords to define folding blocks. This keywords
act a little different then special characters used in C.
Solution: m_virtualColumn was introduced for the startNodes

M  +10   -4    part/syntax/katecodefolding.h
M  +68   -14   part/syntax/katecodefolding.cpp

http://commits.kde.org/kate/b6052e4b8e5b7910ced8c31977a30a14de861961