Bug 278840

Summary:	Dolphin-4.7.0 jpeg preview partially broken
Product:	[Applications] dolphin	Reporter:	l33tmmx
Component:	general	Assignee:	Peter Penz <peter.penz19>
Status:	RESOLVED FIXED
Severity:	normal	CC:	cfeck, mad.f3ka, maxwux
Priority:	NOR
Version:	16.12.2
Target Milestone:	---
Platform:	Gentoo Packages
OS:	Linux
Latest Commit:		Version Fixed In:	4.7.1
Sentry Crash Report:

Description l33tmmx 2011-07-30 09:59:51 UTC

Version:           unspecified (using KDE 4.7.0) 
OS:                Linux

The jpeg preview in dolphin-4.7.0 is partially broken: with icons-view selected there should be small thumbnails of pictures-in-the-folder on top of the folder icon. That still works with gifs, pngs etc. but not any more with jpegs since the upgrade to KDE-4.7.0 (i.e. it used to work on dolphin-4.6.x and earlier). And yes, I have selected the jpeg preview in dolphin settings... And the preview works otherwise, inside the folders, only the small thumbnails-on-folder are missing.

Reproducible: Always

Comment 1 Peter Penz 2011-07-30 15:00:10 UTC

Git commit 17f3cd41665cd9fd3440f51730b9c88b0f7ce8f2 by Peter Penz.
Committed on 30/07/2011 at 16:59.
Pushed by ppenz into branch 'KDE/4.7'.

Fix regression that no JPEG previews are shown for folders

BUG: 278840
FIXED-IN: 4.7.1

M  +1    -1    kioslave/thumbnail/thumbnail.cpp

http://commits.kde.org/kde-runtime/17f3cd41665cd9fd3440f51730b9c88b0f7ce8f2

Comment 2 Peter Penz 2011-07-30 15:01:18 UTC

Git commit b4fa6baef09ca4d49f28f26355b63a18de40143b by Peter Penz.
Committed on 30/07/2011 at 17:00.
Pushed by ppenz into branch 'master'.

Fix regression that no JPEG previews are shown for folders

CCBUG: 278840

M  +1    -1    kioslave/thumbnail/thumbnail.cpp

http://commits.kde.org/kde-runtime/b4fa6baef09ca4d49f28f26355b63a18de40143b

Comment 3 Christoph Feck 2011-07-30 15:08:14 UTC

OMG, I was looking at the code since months, but didn't see what changed. Now it all makes sense. Thanks Peter ;)

Comment 4 Peter Penz 2011-07-30 16:07:03 UTC

@Christoph: This was a really stupid regression that I've introduced myself when merging the rotated JPEG thumbnailer with the "normal" JPEG thumbnailer. But obviously I missed to notice that the previews of JPEGs for folders did not work anymore :-(

Comment 5 Peter Penz 2011-08-01 10:16:17 UTC

*** Bug 279014 has been marked as a duplicate of this bug. ***

Comment 6 Max Wu 2011-09-13 11:01:12 UTC

I use KDE 4.7.1
but the dolphin still can not preview jpeg files

Comment 7 Nikolay Rysev 2011-09-13 11:10:39 UTC

Works for me on 4.7.1

Comment 8 Max Wu 2011-09-13 11:53:24 UTC

I just added a user 
and use the new id to login
and use dolphin
nothing changed
there should be small thumbnails of pictures-in-the-folder on top of the folder
icon
That still works with gifs, pngs etc.

Comment 9 Peter Penz 2011-09-14 10:22:16 UTC

@Max: Could you please check in your distribution whether the kde-baseapps package or Dolphin package really is the 4.7.1 version? Sometimes distributions don't fully upgrade all packages. I cannot reproduce the issue here with 4.7.1. Thanks.