Summary: | can't add contacts in contactlist | ||
---|---|---|---|
Product: | [Frameworks and Libraries] telepathy | Reporter: | Michi <woskimi> |
Component: | contactlist | Assignee: | Telepathy Bugs <kde-telepathy-bugs> |
Status: | RESOLVED FIXED | ||
Severity: | crash | CC: | kde, mklapetek |
Priority: | NOR | ||
Version: | unspecified | ||
Target Milestone: | 0.4.0 | ||
Platform: | openSUSE | ||
OS: | Linux | ||
Latest Commit: | Version Fixed In: |
Description
Michi
2011-07-29 07:26:24 UTC
Is your account (any) connected? Good spot, main-widget.cpp:712 needs a check that the returned account is valid. Checking account->connection() should be safe enough, and catch issues with the account disconnecting too. As for the empty list, I would also guess that one of the accounts is offline. We also hide any accounts which do not support adding of contacts (IRC, for example). I'm confirming the crash is valid, the "empty list" needs more info. - what accounts do you have. - are you sure they were connected. This should probably be a separate bug report to the crash, as they're not related. (In reply to comment #2) > Good spot, main-widget.cpp:712 needs a check that the returned account is > valid. > Checking account->connection() should be safe enough, and catch issues with the > account disconnecting too. > > As for the empty list, I would also guess that one of the accounts is offline. > We also hide any accounts which do not support adding of contacts (IRC, for > example). > > I'm confirming the crash is valid, the "empty list" needs more info. > - what accounts do you have. > - are you sure they were connected. > This should probably be a separate bug report to the crash, as they're not > related. I tried with both bonjour and SIP account, both were connected (I don't know about the situation when I reported, at least it definitely happens when connected too). My google IM account does not connect due to a network error, which I can't track down (have not found any logfiles or anything, so no bug report about that unfortunately). Git commit d19ba7525a6b8e033a6a1e0ad8e548f3d0f186fc by Martin Klapetek. Committed on 13/09/2011 at 12:15. Pushed by mklapetek into branch 'master'. Prevent a crash when no account was selected in the Add Contact dialog or when the connection() of that account is null. BUG: 278757 M +15 -4 main-widget.cpp http://commits.kde.org/telepathy-contact-list/d19ba7525a6b8e033a6a1e0ad8e548f3d0f186fc |