Summary: | Incorrect tab layout with slider/spinbox/reset button | ||
---|---|---|---|
Product: | [Applications] digikam | Reporter: | Frederic Grelot <fredericg_99> |
Component: | Usability-Ergonomy | Assignee: | Digikam Developers <digikam-bugs-null> |
Status: | RESOLVED FIXED | ||
Severity: | normal | CC: | caulier.gilles |
Priority: | NOR | ||
Version: | unspecified | ||
Target Milestone: | --- | ||
Platform: | Compiled Sources | ||
OS: | Linux | ||
Latest Commit: | Version Fixed In: | 6.0.0 |
Description
Frederic Grelot
2011-07-25 18:15:30 UTC
Frederic: Work is needed in two different directions. 1) slider and spinbox come in a single component named KIntNumInput from KDE libraries. There is no clean way to change tab order for us. I would ask you to file a separate bug report against KDE libs: The slide is created after the spinbox, but placed on the left; setTabOrder would be needed to make the tab move from left to right. 2) I fixed the tab order in the resize widget and for the Ok/Cancel buttons below. Which other tools have tab order problems, ignoring the slider/spinbox bug? Note to developers: Apparently tab order is determined by the time the widget is added to its parent, either at construction if the parent is given to the constructor, or when adding to a layout when no parent is given to the constructor. Git commit 1ada12e82688edba047b4a96e8c32f55c11f9203 by Marcel Wiesweg. Committed on 06/08/2011 at 18:04. Pushed by mwiesweg into branch 'master'. Fix tab order for the resize tool and for the EditorTool buttons CCBUG: 278490 M +4 -4 imageplugins/transform/resizetool.cpp M +13 -6 utilities/imageeditor/editor/editortoolsettings.cpp http://commits.kde.org/digikam/1ada12e82688edba047b4a96e8c32f55c11f9203 To Marcel, #1 Thanks for the tab layout tip managed by Qt. I don't know if other tool need to be patched. At least, the most important is to move this file on KDElibs to fix KIntNumInput and KDoubleNumInput widget tab order. Gilles Caulier Fixed since digiKam use pure Qt5 widgets |