| Summary: | crash enabling show menu from the tool menu | ||
|---|---|---|---|
| Product: | [Applications] dolphin | Reporter: | Jaime Torres <jtamate> |
| Component: | general | Assignee: | Peter Penz <peter.penz19> |
| Status: | RESOLVED FIXED | ||
| Severity: | crash | CC: | AGDietrich, andresbajotierra, anishprabu243, campaigner444, cfeck, fisiu82, gilbertoca, jaylotz, kitore, mariustimu, r.schonder, raul.malea, workism |
| Priority: | NOR | ||
| Version: | 16.12.2 | ||
| Target Milestone: | --- | ||
| Platform: | Compiled Sources | ||
| OS: | Linux | ||
| Latest Commit: | Version Fixed In: | ||
| Sentry Crash Report: | |||
| Attachments: |
New crash information added by DrKonqi
New crash information added by DrKonqi |
||
|
Description
Jaime Torres
2011-07-23 23:19:20 UTC
More information... This only happens in 64 bits (or at least not in a VBox 32 bits). When run under valgrind there are 2 write errors and several read errors. I think it's a Qt bug..
I've fixed it locally with
diff --git a/src/gui/widgets/qmenu.cpp b/src/gui/widgets/qmenu.cpp
index 118c073..72cf7da 100644
--- a/src/gui/widgets/qmenu.cpp
+++ b/src/gui/widgets/qmenu.cpp
@@ -1107,7 +1107,7 @@ void QMenuPrivate::activateAction(QAction *action, QAction::ActionEvent action_e
#endif
action->showStatusText(topCausedWidget());
} else {
- actionAboutToTrigger = 0;
+ // actionAboutToTrigger = 0;
}
}
diff --git a/src/gui/painting/qregion.cpp b/src/gui/painting/qregion.cpp
index 821705c..2573492 100644
--- a/src/gui/painting/qregion.cpp
+++ b/src/gui/painting/qregion.cpp
@@ -3649,6 +3649,7 @@ static QRegionPrivate *PolygonRegion(const QPoint *Pts, int Count, int rule)
if (iPts == NUMPTSTOBUFFER) {
tmpPtBlock = (POINTBLOCK *)malloc(sizeof(POINTBLOCK));
Q_CHECK_PTR(tmpPtBlock);
+ memset(tmpPtBlock, 0 , sizeof(POINTBLOCK));
tmpPtBlock->pts = reinterpret_cast<QPoint *>(tmpPtBlock->data);
curPtBlock->next = tmpPtBlock;
curPtBlock = tmpPtBlock;
*** Bug 283274 has been marked as a duplicate of this bug. *** [Comment from a bug report cleaner] - Was the issue reported to Qt devs ? Is there any upstream bug report reference ? Thanks What to write in the bugtracker qt ? What is the reason the bug? Stas: My question was for Jaime, who marked this report to be caused by a bug on Qt libraries. Thanks anyways Thanks Darío, I forgot. https://bugreports.qt.nokia.com/browse/QTBUG-21952 Created attachment 65165 [details]
New crash information added by DrKonqi
dolphin (1.7) on KDE Platform 4.7.2 (4.7.2) using Qt 4.7.4
Still exists on openSUSE 12.1 RC1 x86_64.
-- Backtrace (Reduced):
#7 0x00007febf7fc3436 in operator= (p=0x0, this=0xaf3898) at ../../src/corelib/kernel/qpointer.h:68
#8 QMenuPrivate::activateAction (this=0xaf35d0, action=0x8f2ef0, action_e=QAction::Trigger, self=true) at widgets/qmenu.cpp:1110
#9 0x00007febf982fd40 in KMenu::mouseReleaseEvent (this=0xe4f8f0, e=0x7fff6431f5f0) at /usr/src/debug/kdelibs-4.7.2/kdeui/widgets/kmenu.cpp:464
#10 0x00007febf7bde236 in QWidget::event (this=0xe4f8f0, event=0x7fff6431f5f0) at kernel/qwidget.cpp:8295
#11 0x00007febf7fc497b in QMenu::event (this=0xe4f8f0, e=0x7fff6431f5f0) at widgets/qmenu.cpp:2405
Git commit 4425d906427bf5138d6f26f9ca7d3deabd0659ee by Peter Penz. Committed on 19/11/2011 at 06:49. Pushed by ppenz into branch 'KDE/4.7'. Fix crash when toggling the menu-bar visibility Use a queued connection to prevent that the menu gets hidden during it is still open. Thanks to Christoph Feck for the hint! Frank and I could not reproduce the issue in our environments even when following the steps from bug 278366, however Christoph's hint sounds sane and let's hope it works (leaves a bad gut feeling to "fix" bugs without being able to verify them). BUG: 286822 CCBUG: 278366 FIXED-IN: 4.7.4 M +3 -1 dolphin/src/dolphinmainwindow.cpp http://commits.kde.org/kde-baseapps/4425d906427bf5138d6f26f9ca7d3deabd0659ee Git commit 4f94ca5d90bd346e72878fc44c89f89f06419ed1 by Peter Penz. Committed on 19/11/2011 at 06:49. Pushed by ppenz into branch 'master'. Fix crash when toggling the menu-bar visibility Use a queued connection to prevent that the menu gets hidden during it is still open. Thanks to Christoph Feck for the hint! Frank and I could not reproduce the issue in our environments even when following the steps from bug 278366, however Christoph's hint sounds sane and let's hope it works (leaves a bad gut feeling to "fix" bugs without being able to verify them). CCBUG: 286822 CCBUG: 278366 FIXED-IN: 4.7.4 M +3 -1 dolphin/src/dolphinmainwindow.cpp http://commits.kde.org/kde-baseapps/4f94ca5d90bd346e72878fc44c89f89f06419ed1 I can confirm that your patch fixes the bug for me. I've reverted my changes to Qt, applied your patch. And it works. Very good work. *** Bug 287230 has been marked as a duplicate of this bug. *** *** Bug 287296 has been marked as a duplicate of this bug. *** *** Bug 287566 has been marked as a duplicate of this bug. *** *** Bug 287605 has been marked as a duplicate of this bug. *** *** Bug 287612 has been marked as a duplicate of this bug. *** *** Bug 287634 has been marked as a duplicate of this bug. *** *** Bug 287675 has been marked as a duplicate of this bug. *** *** Bug 287676 has been marked as a duplicate of this bug. *** Good! *** Bug 288742 has been marked as a duplicate of this bug. *** Created attachment 73660 [details]
New crash information added by DrKonqi
dolphin (1.7) on KDE Platform 4.7.2 (4.7.2) "release 5" using Qt 4.7.4
- What I was doing when the application crashed:
I clicked on the configure button and selected the show menu bar option.
- Custom settings of the application:
-- Backtrace (Reduced):
#8 0xb6768565 in QMenu::mouseReleaseEvent(QMouseEvent*) () from /usr/lib/libQtGui.so.4
#9 0xb75c40ec in KMenu::mouseReleaseEvent(QMouseEvent*) () from /usr/lib/libkdeui.so.5
#10 0xb63172ef in QWidget::event(QEvent*) () from /usr/lib/libQtGui.so.4
#11 0xb6766fec in QMenu::event(QEvent*) () from /usr/lib/libQtGui.so.4
#12 0xb62bcee4 in QApplicationPrivate::notify_helper(QObject*, QEvent*) () from /usr/lib/libQtGui.so.4
|