Summary: | Undo History docker has problems with preview icons | ||
---|---|---|---|
Product: | [Applications] krita | Reporter: | Dmitry Kazakov <dimula73> |
Component: | Dockers | Assignee: | Krita Bugs <krita-bugs-null> |
Status: | RESOLVED FIXED | ||
Severity: | normal | CC: | halla |
Priority: | NOR | ||
Version: | git master (please specify the git hash!) | ||
Target Milestone: | --- | ||
Platform: | Unlisted Binaries | ||
OS: | Linux | ||
Latest Commit: | Version Fixed In: |
Description
Dmitry Kazakov
2011-07-16 09:50:46 UTC
There is one more bug possible: The point is the thumbnail is requested from the image on arrival of a signal from the undo stack. Such signal usually comes when the some code calls to undoAdapter->endMacro(). The trouble is that undoAdapter->endMacro() is always called *before* calling setDirty(). It means that requesting the image on QUndoStack::indexChanged() will always generate wrong thumbnail. In most of the cases now, I guess, some timer delay hides this problem, so the bug is not seen usually. But there are cases when it can bee seen. There was a bug [1] (though it had a different nature), but it appeared due to this behavior of the KisUndoModel. [1] - https://bugs.kde.org/show_bug.cgi?id=290563 To me, this now actually looks correct, when painting. Could this have been fixed after merging the strokes stuff? Hm... I don't seen any icons anymore in the undo docker, though the images are still being generated. I think we shouldn't do previews here, but use the tool icons, like Photoshop CS 2. Git commit 7550692bc5747c5c946f94f8d35ce23bbf19e42a by Boudewijn Rempt. Committed on 30/01/2015 at 10:41. Pushed by rempt into branch 'calligra/2.9'. Restore the undo docker preview images M +4 -2 krita/plugins/extensions/dockers/historydocker/KisUndoModel.cpp http://commits.kde.org/calligra/7550692bc5747c5c946f94f8d35ce23bbf19e42a Seems to be fixed now |