Bug 277833

Summary:	okularApplication_mobi.desktop from mobipocket should use TryExec now that it's not shipped together with okular.
Product:	[Applications] okular	Reporter:	Philip Muškovac <yofel>
Component:	general	Assignee:	Okular developers <okular-devel>
Status:	RESOLVED FIXED
Severity:	normal	CC:	debfx-kde
Priority:	NOR
Version:	unspecified
Target Milestone:	---
Platform:	Ubuntu
OS:	Linux
Latest Commit:		Version Fixed In:	4.8

Description Philip Muškovac 2011-07-15 13:15:26 UTC

Version:           unspecified (using Devel) 
OS:                Linux

Filing this against okular since I can't find mobipocket in the kde components list on the bug filing page.

Now that mobipocket has it's own tarball now in 4.7 okularApplication_mobi.desktop should use TryExec=okular to check whether okular is installed or not, since there's no guarantee that okular will be installed together with mobipocket.

Reproducible: Didn't try

Steps to Reproduce:
.

Actual Results:  
.

Expected Results:  
.

Comment 1 Albert Astals Cid 2011-07-18 14:19:34 UTC

The okular code of the mobipocket part is only compiled if okular is present, i disagree with your opinion, if the desktop is there, it is guaranteed that okular is present. You might want to complain to your distro if they do not add the proper dependency check

Comment 2 Felix Geyer 2011-07-20 14:16:46 UTC

The mobipocket tarball contains not only an okular backend but also a strigi and a thumbnailer plugin.
Adding a dependency on okular to the mobipocket package means that you can't use the other plugins without okular.
TryExec=okular in the desktop file allows use to lift that dependency.

Comment 3 Albert Astals Cid 2011-07-20 15:18:54 UTC

If you do not add the dependency means the okular package won't be compiled, so you have the choice of adding the dependencies or of splitting the packages if you want. Anyway it is the packagers problem, the tarball is perfectly correct.

Comment 4 Felix Geyer 2011-07-20 16:05:30 UTC

You are mixing up buildtime and runtime dependencies which can be completely different for binary distributions.
Splitting the packages would be a solution but imho a rather bad one as the plugins are quite small and we don't want to needlessly fragment packages.
So from a packagers POV adding a TryExec key would be the best solution and it basically requires no effort.

Comment 5 Albert Astals Cid 2011-07-20 16:29:08 UTC

Sincerely, I disagree, but i have lots of other battles to fight so if you want to commit a patch, feel free to do it. If you do not have commit access attach the patch and i'll do it for you.

Comment 6 Felix Geyer 2011-11-08 17:29:07 UTC

Git commit b8e524d636da5be90dd9c1f2231d3a4b42d96de1 by Felix Geyer.
Committed on 08/11/2011 at 18:20.
Pushed by fgeyer into branch 'master'.

Add TryExec=okular to okularApplication_mobi.desktop.

This allows distributions to put mobipocket into a single package
that doesn't need to depend on okular.

BUG: 277833
FIXED-IN: 4.8

M  +1    -0    okular/okularApplication_mobi.desktop

http://commits.kde.org/mobipocket/b8e524d636da5be90dd9c1f2231d3a4b42d96de1