Bug 277796

Summary: build failure in the dcraw_emu sample
Product: [Applications] digikam Reporter: tropikhajma <tropikhajma>
Component: Plugin-DImg-RAWAssignee: Digikam Developers <digikam-bugs-null>
Status: RESOLVED FIXED    
Severity: normal CC: caulier.gilles, lexa
Priority: NOR    
Version: 2.0.0   
Target Milestone: ---   
Platform: Compiled Sources   
OS: Solaris   
Latest Commit: Version Fixed In: 2.1.0
Sentry Crash Report:
Attachments: patch

Description tropikhajma 2011-07-14 21:39:25 UTC
Version:           unspecified (using Devel) 
OS:                Solaris

build of libkdcraw 4.6.90 with the sun studio 12u1 compiler fails with the below errors

I don't have a patch ATM

...
pkgbuild: "/home/test/packages/BUILD/libkdcraw-4.6.90/libraw/samples/dcraw_emu.cpp", line 365: Warning (Anachronism): Using int(*)(void*,LibRaw_progress,int,int) to initialize extern "C" int(*)(void*,LibRaw_progress,int,int).
pkgbuild: "/home/test/packages/BUILD/libkdcraw-4.6.90/libraw/samples/dcraw_emu.cpp", line 392: Error: The function "close" must have a prototype.
pkgbuild: "/home/test/packages/BUILD/libkdcraw-4.6.90/libraw/samples/dcraw_emu.cpp", line 395: Error: The function "getpagesize" must have a prototype.
pkgbuild: "/home/test/packages/BUILD/libkdcraw-4.6.90/libraw/samples/dcraw_emu.cpp", line 401: Error: The function "close" must have a prototype.
pkgbuild: "/home/test/packages/BUILD/libkdcraw-4.6.90/libraw/samples/dcraw_emu.cpp", line 404: Error: The function "close" must have a prototype.
pkgbuild: "/home/test/packages/BUILD/libkdcraw-4.6.90/libraw/samples/dcraw_emu.cpp", line 426: Error: The function "close" must have a prototype.
pkgbuild: "/home/test/packages/BUILD/libkdcraw-4.6.90/libraw/samples/dcraw_emu.cpp", line 432: Error: The function "close" must have a prototype.
pkgbuild: "/home/test/packages/BUILD/libkdcraw-4.6.90/libraw/samples/dcraw_emu.cpp", line 436: Error: The function "read" must have a prototype.
pkgbuild: "/home/test/packages/BUILD/libkdcraw-4.6.90/libraw/samples/dcraw_emu.cpp", line 439: Error: The function "close" must have a prototype.
pkgbuild: "/home/test/packages/BUILD/libkdcraw-4.6.90/libraw/samples/dcraw_emu.cpp", line 443: Error: The function "close" must have a prototype.
pkgbuild: 9 Error(s) and 2 Warning(s) detected.


Reproducible: Always

Steps to Reproduce:
try to build


Expected Results:  
builds ok
Comment 1 Alex Tutubalin 2011-07-15 04:28:28 UTC
It looks like some #include missing for Sun. Unfortunately, no Solaris/Sun Studio on hand, so I cannot check.
Comment 2 tropikhajma 2011-08-17 20:13:11 UTC
Created attachment 62913 [details]
patch
Comment 3 caulier.gilles 2011-08-17 20:22:04 UTC
Git commit f346fbb87d5395aea39dc436bab5526038517e79 by Gilles Caulier.
Committed on 17/08/2011 at 22:21.
Pushed by cgilles into branch 'master'.

apply patch #62913
BUGS: 277796

M  +1    -0    libraw/samples/dcraw_emu.cpp

http://commits.kde.org/libkdcraw/f346fbb87d5395aea39dc436bab5526038517e79