Bug 277502

I tried enable debug output with kdedebug dialog, but this is all that happened
when I tried to change the original version view status to permanently hidden
and back:

digikam(22501)/KEXIV2 KExiv2Iface::KExiv2::getImageOrientation: Orientation =>
Exif.Image.Orientation =>  1
digikam(22501)/KEXIV2 KExiv2Iface::KExiv2::getImageOrientation: Orientation =>
Exif.Image.Orientation =>  1

Something I forgot to mention - I see no icon to show its in a version set. The version side-bar appears to recognize there is a version set, but there is no icon in the thumbnail view.

Created attachment 61769 [details]
Digikam DB

I moved my .kde aside and created a 1 image library. When I tried this I saw pretty much the same problem. Both original and final images are shown regardless of what I do.

There was one change - with the cleaned out KDE and digikam settings I now see the filters applied in the Versions tab. In my main digikam setup I do not see this -

> I simple edit a photo then 'Save as New Version'. Both are shown.

Yes, they should. Because you create a "new version", a new line of development, like a branch. To overwrite (virtually), click on Save Changes.

I'll need to check why the hide button in the sidebar does not work. This would be a bug.

(In reply to comment #4)
> > I simple edit a photo then 'Save as New Version'. Both are shown.
> 
> Yes, they should. Because you create a "new version", a new line of
> development, like a branch. To overwrite (virtually), click on Save Changes.
> 

I understand, but I have show original and show intermediate disabled globally, so I expected only the latest version to be displayed in thus configuration, unless I subsequently override this in the version sidebar.

> I understand, but I have show original and show intermediate disabled globally,
> so I expected only the latest version to be displayed in thus configuration,
> unless I subsequently override this in the version sidebar.

Terminology may not be clear.
Consider this completely unrelated image (from Google images):
http://www.ronaldwidha.net/wp-content/uploads/2009/10/branchmangement1_thumb.gif
If you always click Save Changes, you get the blue line.
Show Original determines if "Start" is visible, Short Intermediate determines if feature 1 - feature 4 are visible. Note that you need to request storing intermediates, it's not the default.
If you click Save New Version, you get the yellow lines. You have then three "current versions" which are neither original nor intermediate.

Thanks - I was expecting this feature to work pretty much like Photoshop Elements versioning which it obviously doesn't.

I rechecked the behaviour.

If I edit a photo and just click 'Save' then a _v1 image is created. The original is correctly hidden and I can toggle with the button on the sidebar. All seems well I think (although I was surprised editing _v1 image and clicking 'Save' wanted to overwrite v1 rather than v2 - seemed inconsistent).

Id I edit a photo and click 'Save as version' then a _v1 image is created. The original is incorrectly show and I the side-bar toggle button does not work.

(In reply to comment #7)
> Thanks - I was expecting this feature to work pretty much like Photoshop
> Elements versioning which it obviously doesn't.

WHat does Photoshop do

> If I edit a photo and just click 'Save' then a _v1 image is created. The
> original is correctly hidden and I can toggle with the button on the sidebar.
> All seems well I think (although I was surprised editing _v1 image and clicking
> 'Save' wanted to overwrite v1 rather than v2 - seemed inconsistent).

If you want v2, click Save As New Version.

> Id I edit a photo and click 'Save as version' then a _v1 image is created. The
> original is incorrectly show and I the side-bar toggle button does not work.

The original is shown because it is still at the head of a branch.

> WHat does Photoshop do

http://help.adobe.com/en_US/PhotoshopElements/7.0_Win/WSae2ea3b149d0c3591ae939f103860b3d59-7f5f.html.uk

Is it really a bug or not? How can I get intermediate images? I only can hide original, I never get intermediate versions hidden, neither using save changes, or save new version, neither enabling options

Sergio: Can you give a step-by-step description including set options of what you do to get unhidable intermediate images? Sometimes language is misleading in this context.

I have seen intermediate versions now, for example converting from RAW, applying bright/contrast and saving changes generates two versions: an intermediate version for RAW conversion and a normal version with filter applied.

I thought intermediate versions were saved versions without last version. However if I save changes after RAW conversion, and I save it again after filter applied, I get one version instead of a version and a intermediate version, or two versions. Also saving as new version, I get two versions, but no intermediate version, so I can hide it.

That was my error. Although I would like to get all versions hidden and show last version only, including export to JPEG as last version.

This file still valid using last digiKAm 5.0.0 ?

Gilles Caulier

Since upgrading past 5.0 I've seen part of the issue resolved, but I think they are two issues.

Before 5.0 often I'd have to "unhide" and rehide the base version to get it to hide.

Before and after 5.0 my metadata is often not correct.  I'll have an ID in versions 1 and 2 and a history tag in 2 pointing to ID 1.  Some of my images (including whole directories) are missing metadata.  Perhaps something broke on the original scan.  About 20% of the time I will reload version 1 and then 2, but they won't show up in the versions tab.  I have to reload a few more times.

just updated to Digikam 5.4.0 and this problem still exists. 

if in image editor I set click "save" just _v1 version is created/updated, and original image is preserved, and hidden in thumbnail view.. so this works.

but if I click "save version", a new _v? version is saved, and version tab looks updated nicely.. but, in thumbnail view all versions are always displayed.

clicking the little show/hides in version tab doesn't seem to do anything when there are more than one _v.

I'm on Kubuntu, running ppa version, but I tried the appmage too with same results.


1
.b

Any updates on this? The album view gets cluttered pretty quickly if you edit your photos a lot with versioning.

Please check if with currrent 5.8.0 pre release bundle the problem is reproducible :

https://files.kde.org/digikam/

Gilles Caulier

Unfortunately not resolved in 5.8.0

*** Bug 388227 has been marked as a duplicate of this bug. ***

Created attachment 109527 [details]
versioning.patch

I'm putting this patch up for discussion. The image history and versioning is quite complex. With this patch, the visibility of the original image or intermediate steps would be correct. It is enough to re-read the metadata of a versioned image to repair the entries in the DB.

Maik

Git commit e5fd67611e46ec4553dab5bb7666ecd1df7e4c69 by Maik Qualmann.
Committed on 15/04/2018 at 18:28.
Pushed by mqualmann into branch 'master'.

fix displaying versioned images
FIXED-IN: 6.0.0

M  +2    -1    NEWS
M  +2    -1    core/libs/database/imagehistory/imagehistorygraph.cpp

https://commits.kde.org/digikam/e5fd67611e46ec4553dab5bb7666ecd1df7e4c69

*** Bug 396491 has been marked as a duplicate of this bug. ***

Git commit 00d67e8bbfba047e372374ee7c7c10a9dd1272df by Maik Qualmann.
Committed on 06/03/2019 at 18:52.
Pushed by mqualmann into branch 'master'.

revert patch for the item history
Related: bug 405137
FIXED-IN: 6.1.0

M  +2    -2    NEWS
M  +1    -2    core/libs/database/history/itemhistorygraph.cpp

https://commits.kde.org/digikam/00d67e8bbfba047e372374ee7c7c10a9dd1272df

Read here: https://bugs.kde.org/show_bug.cgi?id=405137#c9

Maik