Bug 277433

also, the calendar an extra column on the right which appears to be the last 6 numerical days of the displayed month

Please attach the screenshot inside the bug report, thanks.

Created attachment 61797 [details]
calendar widget

Platform Version 4.6.95 (4.7 RC2) "release 1"
OpenSuse 64bit

been told the extra column is the week number - so obviously that's not a bug

*** Bug 278860 has been marked as a duplicate of this bug. ***

*** Bug 278673 has been marked as a duplicate of this bug. ***

*** This bug has been confirmed by popular vote. ***

Running KDE 4.7 on Kubuntu 11.04 and I can see the problem.

Rather than just making the fonts smaller, can somebody spend sometime to make the calendar look better? Choose a different font family or decorations if needed. The calendar looks bad compared to the rest of the desktop. It does not have a clean and simple look.

Here is what I think is a nice looking calendar.

http://swipe.nokia.com/img/features/feat-bundle1.jpg

@Dhaval Patel:
Which desktop theme are you using? I can't reproduce it here with trunk and standard Air (German and English).

I've tried about 10 different themes, and the issue is reproduced with any of them. My default theme is Tibanna

Created attachment 62657 [details]
Calendar issue screenshot

This is the Air theme in KDE.

@Jan Gerrit Marker: As you can see from the screenshot I am using the Air theme. The fonts in the calendar are definitely wacked.

I experienced the same problem with KDE SC 4.7.0, but have found that if I hover the mouse cursor over the top left corner of the pop-up calendar, left-click and reduce the size of the pop-up calendar pane, suddenly the font corrects itself and everything fits nicely.

if you make the calendar taller, the effect is even worse.

http://i.imgur.com/L4MgE.png
Please note that this is a regression from 4.6.x
Still not addressed in kde 4.7.1

it seems to ignore my kde font settings. someone said on #kde in freenode that plasma has it's own font settings. how do I change those?

Even if it would respect your font settings, i don't think you can orkaround:(see attachment "taller"

Created attachment 64268 [details]
Taller

I also experience the same bug on a fresh kubuntu 11.10 installation + update to 4.7.2 (official repository).

I am on a fresh install of Kubuntu 11.10 with the standard KDE Software Compilation, Platform Version,  4.1.7, and I experience the same problem. The ugliness of this bug does not belong in KDE!

I am on a fresh install of Kubuntu 11.10 with the standard KDE Software Compilation, Platform Version,  4.1.7, and I experience the same problem. The ugliness of this bug does not belong in KDE!

*** Bug 284754 has been marked as a duplicate of this bug. ***

I had a glance at the code for this, as far as I could read it, the font size is selected at being 90% of the cell height, and at no point has any regard for the font metrics of how wide the text is.

IMHO the calendar should not try scaling, simply load the desktop font sizes, then calculate a sizeHint up front which has enough space for everything.

Git commit 15662dc9ab5a118b5194b7da09951555ebb5e5fc by Fredrik Höglund.
Committed on 29/10/2011 at 19:45.
Pushed by fredrik into branch 'master'.

plasma: Fix text overflow in the calendar widget

BUG: 277433
BUG: 281676

M  +51   -13   libs/plasmaclock/calendartable.cpp

http://commits.kde.org/kde-workspace/15662dc9ab5a118b5194b7da09951555ebb5e5fc

Thank you. Will this be fixed in 4.7 branch as well?

Created attachment 65042 [details]
Too small text

This patch causes the names to be displayed smaller than what I have configured as "Smallest Readable Font". If I cannot read it, it is probably better to not display it at all.

Instead of shrinking the font why not just change the number of letters per pay displayed 

either:
Mo Tu We Th Fr Sa Su
or
M T W T F S S

Created attachment 65052 [details]
Make the week day format size-dependent

This patch makes the calendar switch to a narrower format for the week names when the x-height of the font becomes smaller than 5 pixels.

(In reply to comment #26)
> Thank you. Will this be fixed in 4.7 branch as well?

This fix depends on new API in Qt 4.8 to work properly. Qt 4.8 is not released yet and not tested or recommended with KDE 4.7. I can cherry-pick the patch to the branch, but how well it works when you're using Qt 4.7 may unfortunately depend on how the font is hinted.

(In reply to comment #27)
> This patch causes the names to be displayed smaller than what I have configured
> as "Smallest Readable Font". If I cannot read it, it is probably better to not
> display it at all.

(In reply to comment #28)
> Instead of shrinking the font why not just change the number of letters per pay
> displayed 
> 
> either:
> Mo Tu We Th Fr Sa Su
> or
> M T W T F S S

I have attached a new patch that makes the calendar do this when the font becomes too small.

Please test it and let me know what you think.

(In reply to comment #31)
> (In reply to comment #27)
> > This patch causes the names to be displayed smaller than what I have configured
> > as "Smallest Readable Font". If I cannot read it, it is probably better to not
> > display it at all.
> 
> (In reply to comment #28)
> > Instead of shrinking the font why not just change the number of letters per pay
> > displayed 
> > 
> > either:
> > Mo Tu We Th Fr Sa Su
> > or
> > M T W T F S S
> 
> I have attached a new patch that makes the calendar do this when the font
> becomes too small.
> 
> Please test it and let me know what you think.

I just tried this patch. "M T W T F S S" doesn't look very elegant. "Mo Tu We Th Fr Sa Su" might look better.

(In reply to comment #32)
> I just tried this patch. "M T W T F S S" doesn't look very elegant. "Mo Tu We
> Th Fr Sa Su" might look better.

I agree, but KCalendarSystem in kdelibs currently offers three formats translated to other languages; the full name, a three letter abbreviation, and a single letter abbreviation.

KDE 4.8 will be released with kdelibs 4.7, and we generally don't add new API and features in patch releases.

I'm adding the KCalendarSystem maintainer to the CC list in case he has any comments though.

Date/time formatting standards such as CLDR work with 3 'widths', Long, Short and Narrow, e.g. Monday, Mon and M in English.  Note that different languages/locales may use different number of characters for Short and Narrow, but 3 and 1 is the norm.  The Narrow option was added to kdelibs in 4.7 (?) specifically to solve this bug.

I have no intention to add support for any other formats, especially as 5.0 will be switching to QLocale which will only offer the CLDR standard widths.  If you really must you could provide your own abbreviations and have them translated, but these would be non-standard and not consistent with the rest of KDE and Qt.  Besides, once it gets even smaller then you will just need to switch to 1 char anyway.  I think it would be better to try solve the scaling issue to fit 3 chars in than add all that extra work to save only 1 char.

I haven't checked if this is the case, but when deciding how wide a column must be the code should be checking the max width of all the weekday names displayed to find the widest one, not just the first as it appears to be doing, i.e. Wed is going to be wider than Sun.

FYI, there's a list of various drawing and resizing issues needing to be fixed at http://community.kde.org/Plasma/Tasks#Calendar.2FClock_Plasmoids

Before making any changes I would suggest consulting with aseigo, he has firm opinions on the calendar font dynamic sizing and has rejected patches in the past that wanted to use fixed sizes.  Checking first will save you unnecessary work.

I didn't know I could resize this calendar, so the issue I raised is probably bogus.

Neither did I :-)  - looks much better now - thanks! 

Although I would argue that it would be nice if it was formatted correctly 'out of the box'

How can this be marked as resolved/fixed? The problem still exists in 4.7.4
"release 11".

How is it that it was working in openSUSE 11.4 but broken in 12.1?

Roman, what exactly is broken? The bug was closed as you can resize the calendar. What is the issue you experiment? Please attach a screenshot with default KDE settings to show.

Created attachment 66905 [details]
Default setting of calendar window shows correct format

Default setting of calendar window in openSUSE 11.4.

Created attachment 66907 [details]
Default setting of calendar window shows incorrect format in 12.1

Please note that split window causes calendar columns to appear squeezed in.

Comment on attachment 66907 [details]
Default setting of calendar window shows incorrect format in 12.1

Splitting window gives less real estate to calendar day columns.

Ann-Marie, this can be fixed by assigned more real estate to the calendar. We have 'way' too much space assigned to the holidays side.

I believe that we should have an option to turn off the holiday side. Or allow the the resizing of the holidays side. 

Any thoughts?

I would love to have an options to make that calendar more minimal.

I use KDE because I can make it look clean and simple, but this calendar feels like Windows to me.

http://swipe.nokia.com/img/features/feat-bundle1.jpg is a clean looking calendar. Please make it simpler. If somebody wants to really see other information, they will launch their favorite Scheduling tool.

Dhaval please do not hijack this report for things that are unrelated. If you have a design for the current calendar, please make a mockup, based on the current one. A phone calendar is not a desktop calendar and this particular calendar is not very readable in my opinion, the fonts are way too small and too spaced.

Roman what is your KDE version? this bug report was closed in regard of KDE 4.8 because this is the current development version and the bug you show is fixed.

Apologies Anne-Marie, I was not sure what the appropriate method was to get my opinions heard. I thought it was through these tickets. If you look at comment #9, I posted that link back in early August. Not trying to hujack anything. Just trying to show that it can be cleaner as the posted before me mentioned.

If I do come up with a mockup based on the desktop calendar, where would I upload that to get a discussion around it?

I am using 4.7.4 "release 11". I wish I could have come in sooner.

IMHO This is a combination of poor font, overall design rendering and insufficient real estate for the calendar.

I've also submitted a bugzilla report from our end.

Are you saying that we will not see anything until January 2012?

It seems that font size take into account only height, but it should obey to the minor between both width AND height.

To me it seems, the the approach here is more "designing for the designers/programmers", but not for the users.

I'd clearly vote for user-definable font face and size options in the settings dialog as it's already possible with the font face of (and only) the clock. I'm running a fresh natty-to-oneiric upgrade with 4.7.4.

I use an SXGA display which is not so ultra-high-definition, and the calender fonts could/should be reduced by half(!) for my taste, me not being blind as a mole and liking more padding rather than less. Taste is different, let the people (me!) choose how they like their calendars.