Summary: | Amarok stops to reproduce podcast file before they finished | ||
---|---|---|---|
Product: | [Applications] amarok | Reporter: | Luca <lucabs2112> |
Component: | Playback | Assignee: | Amarok Developers <amarok-bugs-dist> |
Status: | RESOLVED FIXED | ||
Severity: | normal | CC: | bart.cerneels, martin.sandsmark, matej, myriam, tdfischer |
Priority: | NOR | ||
Version: | 2.5.0 | ||
Target Milestone: | 2.6 | ||
Platform: | Ubuntu | ||
OS: | Linux | ||
Latest Commit: | http://commits.kde.org/amarok/e1d2ea6ce3ef61af5dcd4f99db9fb407c95ccb2d | Version Fixed In: | 2.6 |
Description
Luca
2011-07-06 13:27:44 UTC
Same question as the other report: which Phonon backend are you using? The backend setting is Gstreamer. The second choice is Xine. Thank you Thank you for the feedback. FWIW, please do not use the xine backend as it is not maintained anymore, you should use the vlc backend as a fallback instead. Git commit e1d2ea6ce3ef61af5dcd4f99db9fb407c95ccb2d by Matěj Laitl. Committed on 24/07/2012 at 10:59. Pushed by laitl into branch 'master'. EngineController: don't do serious work in slotAboutToFinish() ...because slotAboutToFinish() may be called twice (or not at all) per track by some Phonon backends (hi, vlc) - increase play count rather in slotNewTrackPlaying() or in slotFinished(). This also needs to change how m_currentTrack is handled, because slotNewTrackPlaying() needs to have the old one in m_currentTrack. Also, PlaylistActions::requestNextTrack() is changed to be a read-only method that shouldn't change playlist state especially when there is no next track. PlaylistActions::reflectPlaybackFinished() is introduced to do the thing and is called from EngineController::slotFinished(), which is a much better place for it than slotAboutToFinish(). Reporters of CCed bugs, please re-test your bug with this commit applied, it is possible it has been resolved by this patch. Related: bug 299890, bug 268892, bug 302652, bug 303580, bug 302240 FIXED-IN: 2.6 M +1 -0 ChangeLog M +44 -35 src/EngineController.cpp M +17 -16 src/playlist/PlaylistActions.cpp M +8 -0 src/playlist/PlaylistActions.h http://commits.kde.org/amarok/e1d2ea6ce3ef61af5dcd4f99db9fb407c95ccb2d Luca, has this been fixed with that commit? It seems to be solved! Thanks |