Bug 277120

Summary: Problems with compilation of the sources. use r546
Product: [Unmaintained] valkyrie Reporter: adu
Component: generalAssignee: Cerion Armour-Brown <cerion>
Status: RESOLVED UNMAINTAINED    
Severity: normal CC: cpigat242, stasnel
Priority: HI    
Version First Reported In: unspecified   
Target Milestone: ---   
Platform: Unlisted Binaries   
OS: Linux   
Latest Commit: Version Fixed/Implemented In:
Sentry Crash Report:
Attachments: Patch

Description adu 2011-07-05 09:24:11 UTC
Version:           unspecified (using KDE 1.2) 
OS:                Linux

src/utils/vk_utils.cpp
and
src/utils/vk_config.cpp
and
src/objects/tool_object.cpp:

-----------------------
#include <unistd.h>
-----------------------
should be added in order to get them compiled.

*probably* on developers machines all can be OK.
Because this header file exists in their PATH variable or somewhere else.
But on my machine I can compile the sources only after adding this header in mentioned files.

src/options/suppressions.cpp:
<< "# Date: " + QDateTime::currentDateTimeUtc().toString() << "\n"
currentDateTimeUtc() was introduced only in Qt ver.4.7. BUT all other code is
compatible with Qt 4.5.3 (which I have and I think many people also have).
Obviously that currentDateTime() can be used instead of currentDateTimeUtc() in
this case. And we will not lose something important if we will use non_UTC version of this function.

AND very trivial bug:
src/utils/vk_config.cpp:
VK_DEBUG( "Incompsettingsatible project config: expecting ver:%u, found
ver:%u",

As you may see word 'Incompsettingsatible' - is not a correct english word ;)

Reproducible: Always

Steps to Reproduce:
no need to reproduce - just find&fix mentioned issues.


Expected Results:  
nope.
Comment 1 adu 2011-07-21 15:18:26 UTC
another one small grammar issue:

'Enter Supporessions Filename'. Letter 'o' - should be "killed" ;)

Also - in this dialog I prefer to see next button's order:
YES - NO but in today's dialog I can see NO-YES order...
Comment 2 Dincer Kavraal 2013-10-14 22:31:55 UTC
Created attachment 82853 [details]
Patch

I have been able to compile with the attached patch. I hope it helps all needy.
Comment 3 Andrew Crouthamel 2018-09-04 16:06:18 UTC
Hello! Sorry to be the bearer of bad news, but this project has been unmaintained for many years so I am closing this bug.