Bug 276683

Summary: Krusader includes various 3rd party code that is not updated
Product: [Applications] krusader Reporter: Tomáš Chvátal <scarabeus>
Component: generalAssignee: Krusader Bugs Distribution List <krusader-bugs-null>
Status: RESOLVED FIXED    
Severity: wishlist CC: davide, jan_lepper, krusader-bugs-null
Priority: NOR    
Version First Reported In: 2.4.0-beta1 "Migration"   
Target Milestone: ---   
Platform: Gentoo Packages   
OS: Linux   
Latest Commit: Version Fixed/Implemented In:
Sentry Crash Report:

Description Tomáš Chvátal 2011-06-28 12:01:10 UTC
Version:           2.4.0 (using KDE 4.6.4) 
OS:                Linux

There are various part of krusader that are just copied files / complete 3rd party libs that should not be included and krusader rather should depend on them properly.
Bundling libraries can pose security threat and also disallows users to benefit from feature updates.

Reproducible: Always

Steps to Reproduce:
Just browse the source code

Actual Results:  
Bundled code/libs are found.

Expected Results:  
Nothing copied from other projects is found

These are the things i was able to identify:
tar/tar.{h,cc} - kdelibs provided ktar.h and friends.
iso/libisofs - is bundled library from http://libcdrom.sourceforge.net/libisofs.html at version 0.2, current version is at 0.4.
Comment 1 Davide Gianforte 2020-05-03 05:08:08 UTC
Tar code is no more used. Libisofs does not provide relevant changes to the current code.