Bug 276677

Summary:	In Krita Alpha-2, the Pressure curves of Size and Opacity are not saved in the brush presets
Product:	[Applications] krita	Reporter:	ALeXeY <alexeyn3d>
Component:	Brush engines	Assignee:	Krita Bugs <krita-bugs-null>
Status:	RESOLVED FIXED
Severity:	normal	CC:	halla
Priority:	NOR
Version:	2.4-snapshots
Target Milestone:	---
Platform:	Ubuntu
OS:	Linux
Latest Commit:		Version Fixed In:

Description ALeXeY 2011-06-28 11:09:10 UTC

Version:           2.4-snapshots (using KDE 4.5.5) 
OS:                Linux

The following was noted in Krita Alpha-2 (downloaded and compiled Jun 26, 2011).

When I edit the Size or Opacity Pressure curve in Pixel or Smudge Brush, save a preset and load it back, then the curve is reset to default. And these curves have no effect even before save / load. 

This occurs only when modifying a curve in the preset, which have not curve previously edited (i.e., have a default straight line). If the preset (from Krita Alpha-1) have previously edited curve, I can edit it, save, load and the curve is not disappears.

Also, when I turn on some other tablet modifier in Size property settings (Fuzzy for example), the Pressure curve begin to work, and can be saved/loaded. 

Reproducible: Always

Steps to Reproduce:
In Pixel brush engine settings window, add some points to Size Pressure curve, save a preset and load it. 

Actual Results:  
The curve reset to default straight line

Expected Results:  
Curves must normally save and load

OS: Linux (x86_64) release 2.6.35-30-generic (Ubuntu 10.10)
Compiler: cc

Comment 1 Halla Rempt 2011-06-28 11:11:38 UTC

Thanks for the report!

Comment 2 ALeXeY 2011-06-29 17:42:51 UTC

On Sabayon Linux (Gentoo-based), the bug is still present.

Comment 3 ALeXeY 2011-06-29 17:46:25 UTC

2.6.39-sabayon
KDE 4.6.4

Comment 4 Halla Rempt 2011-07-07 09:36:34 UTC

Confirmed.

Comment 5 Sven Langkamp 2011-07-08 21:32:35 UTC

Git commit a3f047dfe13da2d33a2dc2b7ddfb59479a441395 by Sven Langkamp.
Committed on 08/07/2011 at 23:29.
Pushed by langkamp into branch 'master'.

fix loading of curve when old and new data is in the file
BUG:276677

M  +7    -5    krita/plugins/paintops/libpaintop/kis_curve_option.cpp     

http://commits.kde.org/calligra/a3f047dfe13da2d33a2dc2b7ddfb59479a441395

Comment 6 ALeXeY 2011-07-11 12:16:21 UTC

Thanks for a good job!