Summary: | Amarok current track applet layout is broken when the font size is more than 9. | ||
---|---|---|---|
Product: | [Applications] amarok | Reporter: | Sergey Malkin <adresatt> |
Component: | Context View/Current Track | Assignee: | Amarok Developers <amarok-bugs-dist> |
Status: | RESOLVED FIXED | ||
Severity: | minor | CC: | akhilman, anton, dmitry, e.m.a.t.i.r.o.v, edward.hades, jeorgun, lfranchi, ripper, simon.esneault, tuomas, vianasw, zawertun |
Priority: | NOR | ||
Version First Reported In: | 2.8.0 | ||
Target Milestone: | later | ||
Platform: | Arch Linux | ||
OS: | Linux | ||
Latest Commit: | Version Fixed In: | ||
Sentry Crash Report: | |||
Attachments: |
Amarok current track applet bag
12px font, corrupted after restart similar to comment 1 2.7 with LANG=ru_RU.UTF-8 and MS Trebuchet 13 screenshot shows buggy current track applet with russian locale Quick and dirty patch Another try, still it's very ugly solution |
Description
Sergey Malkin
2011-06-28 09:58:38 UTC
Created attachment 61404 [details]
Amarok current track applet bag
I can't reproduce this here at all, tried with font sizes 10, 11 and 12, everything displays as it should. Testing with current Amarok 2.4-git on Kubuntu 11.04 with KDE 4.6.4 I've pulled last GIT build and there everything is really Ok. I'm looking forward for the next release. Reproducible for Amarok 2.7.0. It appears only on Russian locale, on English everything is good. Created attachment 78196 [details] 12px font, corrupted after restart similar to comment 1 Why would this only appear on Russian locale, do you use a different font? Is it a proportional or a fixed-width font? (In reply to comment #6) > Why would this only appear on Russian locale, do you use a different font? > Is it a proportional or a fixed-width font? Sans serif (arial) in both cases. It seems words are too big somewhere. On English locale it corrupted with font size 16. Confirmed on 2.7 with LANG=ru_RU.UTF-8 and Sans Serif 12 Confirmed on 2.7 with LANG=ru_RU.UTF-8 and MS Trebuchet 13 Created attachment 78571 [details]
2.7 with LANG=ru_RU.UTF-8 and MS Trebuchet 13
Can't reproduce in v2.8.0 (In reply to comment #11) > Can't reproduce in v2.8.0 You did test with the Russian locale? as it is not reproducible with an English one anyway. (In reply to comment #12) > (In reply to comment #11) > > Can't reproduce in v2.8.0 > > You did test with the Russian locale? as it is not reproducible with an > English one anyway. Ooops, sorry, my fault. :( So, I can reproduce it. Confirmed with the Russian locale, as before. If somebody has an idea how to solve that... This bug is still present for me on 2.8.0 with LANG=en_US.UTF-8 and font size > 15, for what it's worth. Created attachment 87617 [details]
screenshot shows buggy current track applet with russian locale
In my case I have only album art and stars and nothing else in current track widget. Once again runing with LANG=C solves problem.
I can confirm this issue with Version 2.8.0, KDE 4.14.0, openSUSE 13.1 with german locale, DPI for fonts forced to 148 (or higher). If I'm not forcing the DPI or forcing it to less than 148 (so 147 is the last setting that works), it goes back to normal. Other font settings are default. My screen (as reported by xdpyinfo): dimensions: 1920x1080 pixels (508x285 millimeters) resolution: 96x96 dots per inch Why do you force DPI to start with? This should be left out so the system can calibrate itself, which is especially useful on large resolutions. Because I have screen with high density and not very high eyesight. So I increase scale of all texts in my system to see it. (In reply to Myriam Schweingruber from comment #18) > Why do you force DPI to start with? This should be left out so the system > can calibrate itself, which is especially useful on large resolutions. Created attachment 93901 [details]
Quick and dirty patch
It's better than nothing (7px wide widget I mean). Sadly but after applying this patch no song info will be displayed, only album cover, song rating and statistics info would be visible. (In reply to Yaroslav Sidlovsky from comment #20) > Created attachment 93901 [details] > Quick and dirty patch Thank you for this patch. Could you please submit it to reviewboard.kde.org, and subscribe the group Amarok to it? Thank you. Sorry, but that's totally wrong patch. I can't tell why on one of my machines (with same DPI and font configuration) sizeHint method returns preffered width of 7 px. Maybe this is a bug in the Qt 4. Who knows... Also code that relates to widget size calculation was significantly changed in the last Amarok version (2.8.90 version). Maybe this bug will disappear. Created attachment 93915 [details]
Another try, still it's very ugly solution
Commented out line 172 in the CurrentTrack.cpp because without this change I don't see title, artist and album info strings.
Tried changing language, seems to be fixed in 2.9.71, probably by the port to KF5 and the extensive code changes in context view. |