Bug 276276

Summary:	SMS length should be limited to 70 chars when using non-ascii chars
Product:	[Applications] kdepimlibs	Reporter:	Alexander Potashev <aspotashev>
Component:	kabc	Assignee:	kdepim bugs <kdepim-bugs>
Status:	RESOLVED UNMAINTAINED
Severity:	normal	CC:	montel
Priority:	NOR
Version:	4.6
Target Milestone:	---
Platform:	Gentoo Packages
OS:	Linux
Latest Commit:		Version Fixed In:	4.7.2
Sentry Crash Report:

Description Alexander Potashev 2011-06-22 19:36:44 UTC

Version:           4.6 (using KDE 4.6.4) 
OS:                Linux



Reproducible: Didn't try

Steps to Reproduce:
1. open KAddressBook
2. Find a contact with a cell phone specified
3. click on "SMS" on the right side panel, the "SMS text" dialog opens
4. type some non-ascii text (for example, in Russian)

Actual Results:  
The label under the text input box says "6/160 (1 SMS)"

Expected Results:  
Should be "6/70 (1 SMS)", because one SMS message can contain only up to 70 unicode (16-bit) characters.

Comment 1 Laurent Montel 2011-09-04 17:35:59 UTC

It"s right:
"http://en.wikipedia.org/wiki/SMS"
"Depending on which alphabet the subscriber has configured in the handset, this leads to the maximum individual short message sizes of 160 7-bit characters, 140 8-bit characters, or 70 16-bit characters (including spaces). "

We must to fix it.

Comment 2 Laurent Montel 2011-09-04 17:38:32 UTC

./akonadi/contact/actions/smsdialog.cpp:

Comment 3 Laurent Montel 2011-09-14 12:01:38 UTC

Git commit 8983a4773e02edecb015a3f29ae2f4fc06ca35ad by Montel Laurent.
Committed on 14/09/2011 at 14:00.
Pushed by mlaurent into branch 'master'.

Fix bug 276276 SMS length should be limited to 70 chars when using non-ascii chars

Thanks to David for his help
FIXED-IN: 4.7.2
BUG: 276276

M  +14   -6    akonadi/contact/actions/smsdialog.cpp

http://commits.kde.org/kdepimlibs/8983a4773e02edecb015a3f29ae2f4fc06ca35ad

Comment 4 Laurent Montel 2011-09-14 12:02:13 UTC

Git commit 463813dbdf9657c7e352a1f4ee44ea584d54d821 by Montel Laurent.
Committed on 14/09/2011 at 14:00.
Pushed by mlaurent into branch '4.7'.

Fix bug 276276 SMS length should be limited to 70 chars when using non-ascii chars

Thanks to David for his help
FIXED-IN: 4.7.2
BUG: 276276
(cherry picked from commit 8983a4773e02edecb015a3f29ae2f4fc06ca35ad)

M  +14   -6    akonadi/contact/actions/smsdialog.cpp

http://commits.kde.org/kdepimlibs/463813dbdf9657c7e352a1f4ee44ea584d54d821

Comment 5 Alexander Potashev 2011-09-14 14:26:28 UTC

1. "bool noLatin1Char" is not used.
2. Checking for "row() > 0" is (probably) not correct. This condition (row > 0) makes U+0080..U+00FF characters acceptable for a 160-char-long message, but they are not. "ASCII chars" are only U+0000..U+007F.

Comment 6 Denis Kurz 2016-09-24 20:55:58 UTC

This bug has only been reported for versions before 4.14, which have been unsupported for at least two years now. Can anyone tell if this bug still present?

If noone confirms this bug for a Framework-based version of kdepim (version 5.0 or later, as part of KDE Applications 15.08 or later), it gets closed in about three months.

Comment 7 Denis Kurz 2017-01-07 22:42:23 UTC

Just as announced in my last comment, I close this bug. If you encounter it again in a recent version (at least 5.0 aka 15.08), please open a new one unless it already exists. Thank you for all your input.