Bug 276151

Summary:	PYTHON_INSTALL macro should respect PYTHONDONTWRITEBYTECODE environmental variable
Product:	[Developer tools] buildsystem	Reporter:	Arfrever Frehtes Taifersar Arahesis <Arfrever.FTA>
Component:	KDE4 (cmake)	Assignee:	Alexander Neundorf <neundorf>
Status:	RESOLVED FIXED
Severity:	normal	CC:	scarpino, stupor_scurvy343, tampakrap, winter
Priority:	NOR
Version:	unspecified
Target Milestone:	---
Platform:	unspecified
OS:	All
Latest Commit:	http://commits.kde.org/kdelibs/5a3cedacdb6485f7551090467cffb2cdf150b05a	Version Fixed In:
Sentry Crash Report:
Attachments:	Respect PYTHONDONTWRITEBYTECODE environmental variable in PYTHON_INSTALL macro Updated patch for kdelibs 4.9.3 Updated patch for kdelibs KDE/4.10 branch

Description Arfrever Frehtes Taifersar Arahesis 2011-06-20 22:11:52 UTC

Created attachment 61183 [details]
Respect PYTHONDONTWRITEBYTECODE environmental variable in PYTHON_INSTALL macro

Version:           unspecified (using KDE 4.6.4) 
OS:                All

cmake/modules/PythonMacros.cmake defines PYTHON_INSTALL macro. This macro should not create/install byte-compiled Python modules (*.pyc) when PYTHONDONTWRITEBYTECODE environmental variable is set.

See also: http://docs.python.org/using/cmdline.html#envvar-PYTHONDONTWRITEBYTECODE

Reproducible: Always

Comment 1 Allen Winter 2011-06-21 02:53:56 UTC

It would be nice if you would post this patch to git.kdereviewboard.kde.org
under the buildsystem group.

Comment 2 Andrea Scarpino 2012-11-06 10:39:04 UTC

Created attachment 75050 [details]
Updated patch for kdelibs 4.9.3

Comment 3 Andrea Scarpino 2012-11-06 10:51:03 UTC

https://git.reviewboard.kde.org/r/107228/

Comment 4 Arfrever Frehtes Taifersar Arahesis 2012-11-07 18:53:41 UTC

Created attachment 75083 [details]
Updated patch for kdelibs KDE/4.10 branch

Comment 5 stupor_scurvy343 2012-11-07 19:14:04 UTC

Git commit 352ceb824ab7b6425bbb470d2231f76704fc3a10 by Michael Palimaka, on behalf of Arfrever Frehtes Taifersar Arahesis.
Committed on 07/11/2012 at 20:08.
Pushed by palimaka into branch 'KDE/4.9'.

Respect PYTHONDONTWRITEBYTECODE environmental variable.
REVIEW: 107228

M  +43   -41   cmake/modules/PythonMacros.cmake

http://commits.kde.org/kdelibs/352ceb824ab7b6425bbb470d2231f76704fc3a10

Comment 6 stupor_scurvy343 2012-11-07 19:29:51 UTC

(In reply to comment #4)
> Created attachment 75083 [details]
> Updated patch for kdelibs KDE/4.10 branch
https://git.reviewboard.kde.org/r/107248/

Comment 7 Arfrever Frehtes Taifersar Arahesis 2012-11-07 20:15:24 UTC

Fix was committed also in KDE/4.10 branch.

Comment 8 David Faure 2012-11-08 18:43:10 UTC

Git commit 5a3cedacdb6485f7551090467cffb2cdf150b05a by David Faure, on behalf of Arfrever Frehtes Taifersar Arahesis.
Committed on 07/11/2012 at 20:08.
Pushed by dfaure into branch 'KDE/4.9'.

Respect PYTHONDONTWRITEBYTECODE environmental variable.
REVIEW: 107228

M  +43   -41   cmake/modules/PythonMacros.cmake

http://commits.kde.org/kdelibs/5a3cedacdb6485f7551090467cffb2cdf150b05a

Comment 9 stupor_scurvy343 2012-11-11 15:05:15 UTC

I am a bit confused, it looks like the fix was committed to KDE/4.9 twice?

Comment 10 Christoph Feck 2012-11-11 17:27:58 UTC

Michael, it had to be repushed, because of a branching problem. Everything is fine now :)