| Summary: | translated presence strings in the presence applet | ||
|---|---|---|---|
| Product: | [Unmaintained] telepathy | Reporter: | George Goldberg <grundleborg> |
| Component: | presence-applet | Assignee: | Telepathy Bugs <kde-telepathy-bugs> |
| Status: | RESOLVED FIXED | ||
| Severity: | normal | CC: | francesco.nwokeka, kde |
| Priority: | NOR | ||
| Version: | unspecified | ||
| Target Milestone: | 0.4.0 | ||
| Platform: | Unlisted Binaries | ||
| OS: | Linux | ||
| Latest Commit: | Version Fixed In: | ||
| Sentry Crash Report: | |||
| Bug Depends on: | |||
| Bug Blocks: | 232378 | ||
|
Description
George Goldberg
2011-06-15 15:51:54 UTC
Just actually checked the source code. The code is being translated. It's simply missing a capital letter at the start of each word, and maybe "dnd" -> "Busy". DND != Busy. With DND you say "do not write me now (I'm watching movie, I'm on a meeting etc)" while Busy says "I'm busy, I might respond later". I agree with your sentiment, but I was referring to converting the simple presence type enum value which is called busy to the string "dnd". Really the whole thing is wrong as the dataengine should be passing the presence status, not the simpler enum value. In that case we can treat "dnd" and "busy" differently. So this is to be modified in the dataengine. I can do this in two ways: 1 - modify the "dnd" string i get from the dataengine and save it as "busy" (this would be redundant with the var PresenceType 2 - eliminate the var PresenceStatus and use the PresenceType to indicate presence status in the applet. Git commit 44dadfb3fe7929754f5c4d9af3bf912d64bdbc29 by Francesco Nwokeka. Committed on 12/07/2011 at 16:45. Pushed by nwokeka into branch 'master'. FIX presence status messages All presence status messages are translated and start with an upper case letter. This fix makes Martin a happy man! BUG: 275719 M +29 -5 package/contents/ui/PresenceChooser.qml http://commits.kde.org/telepathy-presence-applet/44dadfb3fe7929754f5c4d9af3bf912d64bdbc29 |