Bug 275477

Summary:	Add support for opening links in new window when started from command line
Product:	[Unmaintained] rekonq	Reporter:	Pali Rohár <pali.rohar>
Component:	general	Assignee:	Andrea Diamantini <adjam7>
Status:	RESOLVED FIXED
Severity:	wishlist
Priority:	NOR
Version:	0.7.0
Target Milestone:	0.9
Platform:	Ubuntu
OS:	Linux
Latest Commit:		Version Fixed In:
Sentry Crash Report:
Attachments:	patch which always open URL from command line in new window Patch

Description Pali Rohár 2011-06-12 16:14:06 UTC

Version:           0.7.0 (using KDE 4.6.4) 
OS:                Linux

Now behavior of opening new links in rekonq can be configured in Tabs panel with checkbox "Open links in new tab instead new window"

I want configure rekonq for this:
1. Open all links in new tab
2. When opening URL from console (when I start new process: $ rekonq URL) open this URL in new window instead new tab

It is not possible because 2. is controlled by same checkbox as 1.

I'm attaching simple patch which change opening 2. to new window.

Reproducible: Always




OS: Linux (x86_64) release 2.6.38.7
Compiler: cc

Comment 1 Pali Rohár 2011-06-12 16:15:36 UTC

Created attachment 60931 [details]
patch which always open URL from command line in new window

Comment 2 Andrea Diamantini 2011-06-12 18:38:35 UTC

I understand the way you'd like rekonq behaves. What you didn't explain is: why?

Comment 3 Pali Rohár 2011-06-23 01:23:54 UTC

Why I need this behavior? Because If I opening URL from other application (Kopete, Kmail, Konsole) or need to run "new instance" of rekonq, I need to separate context.

My attached patch is my quick & dirty solution. I think that this option could be configured in Settings dialog.

Comment 4 Pali Rohár 2011-07-20 14:49:45 UTC

Any news about adding option for configuring this?

Comment 5 Pali Rohár 2011-08-15 14:35:55 UTC

Created attachment 62844 [details]
Patch

This patch create proper new option in Tab Dialog for this issue instead harcoded changes.

Comment 6 Andrea Diamantini 2011-08-21 15:48:23 UTC

it has been decided to not include this feature after a discussion in our mailinglist, sorry.

Comment 7 Pali Rohár 2011-08-21 17:03:10 UTC

see my post on reviewboard: https://git.reviewboard.kde.org/r/102330/

Comment 8 Andrea Diamantini 2011-08-23 09:59:58 UTC

(In reply to comment #6)
> it has been decided to not include this feature after a discussion in our
> mailinglist, sorry.

Sorry, I wrote this in the wrong place. Reopening as "stupidly closed" :)

Comment 9 Andrea Diamantini 2012-01-02 15:31:06 UTC

I think this has been merged with the option "open external links in new window"