Bug 275139

Summary: Krita color source in brush engine bad behaviour.
Product: [Applications] krita Reporter: RamonMiranda <mirandagraphic>
Component: Brush enginesAssignee: Dmitry Kazakov <dimula73>
Status: RESOLVED FIXED    
Severity: normal CC: halla
Priority: NOR    
Version: git master (please specify the git hash!)   
Target Milestone: ---   
Platform: Compiled Sources   
OS: Linux   
Latest Commit: Version Fixed In:
Sentry Crash Report:

Description RamonMiranda 2011-06-07 19:28:34 UTC 
Version:           svn trunk (using KDE 4.5.5) 
OS:                Linux

It seems that color source inside the brush engine (PIXEL BRUSH). is not working properly. i have tested all the modes. and "Darken" and "Airbrush" are not working.

Reproducible: Always

Steps to Reproduce:
Select a brush and select the color source "darken" or "airbrush" and make a brushstroke.brush beahaviour is normal, not altered for the color source.
Comment 1 Halla Rempt 2011-06-07 20:06:32 UTC 
Confirmed after testing Ramon. The Darken option isn't completely inactive, but does "too little".
Comment 2 Dmitry Kazakov 2012-11-07 15:07:36 UTC 
Hi!

Could you elaborate a bit what is needed from the Darken option? Should it just be lighter? Or there is something else? Could you add a snapshot?
Comment 3 Dmitry Kazakov 2012-11-07 15:41:23 UTC 
Git commit 3b587128772fbae3fd7a0ff718627328fa1fc2af by Dmitry Kazakov.
Committed on 07/11/2012 at 16:40.
Pushed by dkazakov into branch 'krita-new-move-tool-kazakov'.

Made the darken option to work full-range

Now the darken option works with full range of effect (0-255).
If you want to limit the "darkness" of the brush, just use the slider
on the top of the configuration dialog.

M  +3    -2    krita/plugins/paintops/libpaintop/kis_pressure_darken_option.cpp

http://commits.kde.org/calligra/3b587128772fbae3fd7a0ff718627328fa1fc2af
Comment 4 Dmitry Kazakov 2012-11-13 04:30:08 UTC 
Git commit a0119b6f1b8d5f24839188f79b006796ff24b1f8 by Dmitry Kazakov.
Committed on 07/11/2012 at 16:40.
Pushed by dkazakov into branch 'calligra/2.6'.

Made the darken option to work full-range

Now the darken option works with full range of effect (0-255).
If you want to limit the "darkness" of the brush, just use the slider
on the top of the configuration dialog.

M  +3    -2    krita/plugins/paintops/libpaintop/kis_pressure_darken_option.cpp

http://commits.kde.org/calligra/a0119b6f1b8d5f24839188f79b006796ff24b1f8