| Summary: | id3v2 TAG frame parsing stops when a zero size frame is analyzed. | ||
|---|---|---|---|
| Product: | [Frameworks and Libraries] taglib | Reporter: | Giuseppe Meloni <peps85> |
| Component: | general | Assignee: | Scott Wheeler <wheeler> |
| Status: | RESOLVED WORKSFORME | ||
| Severity: | normal | CC: | ballo_lev, cpigat242, lalinsky |
| Priority: | NOR | ||
| Version: | 1.7 | ||
| Target Milestone: | --- | ||
| Platform: | Compiled Sources | ||
| OS: | Other | ||
| Latest Commit: | Version Fixed In: | ||
| Sentry Crash Report: | |||
| Attachments: | Simple workaround patch | ||
Here finde an example file: http://cting.org/~peps/example.mp3 Created attachment 64182 [details]
Simple workaround patch
It's definitely terrible issue from my point of view.
I faced with zero-sized MCDI frame.
I have to use attached patch as workaround fir the problem with zero-sized frames.
Here's zero-sized MCDI frame: http://shareflare.net/download/14096.1cbb6b66744b25cb397b1cbfbaa2/I_Luv_It.mp3.html Thank you for reporting this bug in KDE software. As it has been a while since this issue was reported, can we please ask you to see if you can reproduce the issue with a recent software version? If you can reproduce the issue, please change the status to "CONFIRMED" when replying. Thank you! Dear Bug Submitter, This bug has been in NEEDSINFO status with no change for at least 15 days. Please provide the requested information as soon as possible and set the bug status as REPORTED. Due to regular bug tracker maintenance, if the bug is still in NEEDSINFO status with no change in 30 days the bug will be closed as RESOLVED > WORKSFORME due to lack of needed information. For more information about our bug triaging procedures please read the wiki located here: https://community.kde.org/Guidelines_and_HOWTOs/Bug_triaging If you have already provided the requested information, please mark the bug as REPORTED so that the KDE team knows that the bug is ready to be confirmed. Thank you for helping us make KDE software even better for everyone! This bug has been in NEEDSINFO status with no change for at least 30 days. The bug is now closed as RESOLVED > WORKSFORME due to lack of needed information. For more information about our bug triaging procedures please read the wiki located here: https://community.kde.org/Guidelines_and_HOWTOs/Bug_triaging Thank you for helping us make KDE software even better for everyone! |
Version: 1.7 (using KDE 4.6.3) OS: other Some files have one or more id3v2 frames with zero size. A lot of them are WMA converted to MP3 and have several WM/Private tag with zero size. Also, sometimes the tags WOAF, WOAR and WOAS have the size = 0. So the check in the following code stops the parsing end all tags after the 0 size frame are skipped (ie APIC tag). // Checks to make sure that frame parsed correctly. if(frame->size() <= 0) { delete frame; return; } Probably my test files are not fully compliant with the id3v2 specification, but there is a way to solve this problem? At the moment I've just comment out the frame size check. Reproducible: Always Steps to Reproduce: Try to parse the attached file Taglibe doesn't retrieve the cover art, while almost all tag editor yes. Actual Results: No Cover is retrieved. Expected Results: Taglib should "see" the cover art inside the file.